Printable View
Up till now I have been using the
m_progress.SetPos(m_progress.GetPos() + 60);
respectively. Only problem occurs is when a large file is being copied over, say 8-10MB. The bar just hangs until the file is copied over and then adjust to my calculation of completness. How can I configure a progress bar to realtime?
Are you doing the file copy in the program's main thread?
Or are you creating a worker thread to do the copy?
Any action that takes a "long" time should be placed into a worker
thread. If something takes a long time, then the main window
cannot get updated periodically.
If you use the main thread for the copy, then you need to create
a worker thread and do the work there.
Probably the file copy is preventing messages from being processed. I think the FAQ has some answers. Also my Idle-time Processing might help.
I would take exception to that as a generalization. Worker threads can be useful if other work can be done while a background task is running. There's no point in creating a thread and the issues that go with synchronizing multiple threads if it doesn't enable the user to be more productive.Quote:
Originally posted by cvogt61457
Are you doing the file copy in the program's main thread?
Or are you creating a worker thread to do the copy?
Any action that takes a "long" time should be placed into a worker
thread. If something takes a long time, then the main window
cannot get updated periodically.
If you use the main thread for the copy, then you need to create
a worker thread and do the work there.
In this case if he's using CopyFile, he just isn't getting any progress messages until the copy is complete. There isn't much he can do about that unless he writes the copy code himself.
If that is the only alternative then a worker thread is a useful solution.Quote:
Originally posted by GCDEF
There isn't much he can do about that unless he writes the copy code himself.
I am using a modal dialog with the progress bar and code with it. It works well. Until the file copy process is complete, I do not want the Parent dialog (I assume this is what is ment by main thread) to gain focus. And it doesn't, if a user clicks on it, it simply shows the "not responding message". This is Ok.
I guess I'm trying to get something closer like you would see on a download from the internet. You can download winzip from download.com or else were. Even though it is a 1-3MB file, you still get a download progress that is incremental during the downloading of the file.
But he still won't get status back from CopyFile indicating how much of the file is done. As I understand his problem he gets a large jump in his progress bar after a large file is copied. To avoid that he'd have to write a copy function himself (which would be all of 20 lines of code or so) and then he'd know how much of the file he'd copied and could update his progress bar as the file was copied.Quote:
Originally posted by Sam Hobbs
If that is the only alternative then a worker thread is a useful solution.
In this case I don't think a thread buys him anything at all.
Who says CopyFile is being used? As far as I can tell, you are the only one that says it is and therefore it is only a guess. However, yes, there is not a callback from CopyFile, but there is from CopyFileEx. Perhaps CopyFileEx can be used; I don't know if it will show progress automatically but it does have a callback that is explicitly for showing a progress bar.Quote:
Originally posted by GCDEF
But he still won't get status back from CopyFile indicating how much of the file is done.
I did say "if" he's using CopyFile, but yes you are correct. Anything that will give him a status of the copy in progress will work fine. Still, a thread by itself as suggested, will do nothing to solve the problem, and that was my point.Quote:
Originally posted by Sam Hobbs
Who says CopyFile is being used? As far as I can tell, you are the only one that says it is and therefore it is only a guess. However, yes, there is not a callback from CopyFile, but there is from CopyFileEx. Perhaps CopyFileEx can be used; I don't know if it will show progress automatically but it does have a callback that is explicitly for showing a progress bar.
If the problem is that messages are not being processed, then a thread is a possible solution.Quote:
Originally posted by GCDEF
a thread by itself as suggested, will do nothing to solve the problem, and that was my point.
Having a thread to copy the file won't help with the progress bar
unless some other file copy method is used (CopyFileEx is alot
better than a thread and does provide progress data)
How are you copying the file and what are the source and destinations?
Is the transfer divided into blocks that you have control over the
data flow? Or is it a single call to the OS that returns when the
file transfer has been completed?
How you do the transfer will determine how you will need to
update the progress bar.
With the IE example that you had, the file is being received from
the host in blocks of data. If the size is known, then as each
block is received, update the bytes received and use this in your
progress bar.
[Note: In my original message, I didn't connect the progress bar
to the file copy. Probably should have. Should have guessed that
the file being copied was the reason for the progress bar - Doh!!]
Well..if you are displaying a modal dialog while doing the file copy the parent dialog cannot be used for user input by default. However, if you are experiencing problems updating the progress bar of your modal dialog, it depends where and how you actually do the file copy. If you are doing the file copy within the main thread of the modal dialog, processing of the message queue will be interrupted for the time the copy will take. There are several solutions depending on the actual copy function...so the question would simply be: Where and how do you do the file copy?Quote:
Originally posted by jkw2068
I am using a modal dialog with the progress bar and code with it. It works well. Until the file copy process is complete, I do not want the Parent dialog (I assume this is what is ment by main thread) to gain focus. And it doesn't, if a user clicks on it, it simply shows the "not responding message". This is Ok.
Guys. Thanks. Sorry for any frustration if any. I do like the attention and all. :D Sorry. In fact, I am using CopyFile(). If CopyFileEx() might provide a solution, I'll look into that. If needed, I'll do some reaserch on worker threads. If anyone else has any brain farts. let me know. Thanks
Well...that answers the question of how you doing the file copy...nevertheless not the one where you actually do it... :cool:
Quote:
Originally posted by Andreas Masur
nevertheless not the one where you actually do it... :cool:
Not sure what is meant by this. Could you explain please?
The CopyFile() function is being used to simply copy the source file selected by the user via the CFileDialog to its destination. Default is the floppy drive.
Looks promising. Wish MSDN had some samples though.
BOOL CopyFileEx(
LPCTSTR lpExistingFileName,
LPCTSTR lpNewFileName,
LPPROGRESS_ROUTINE lpProgressRoutine,
LPVOID lpData,
LPBOOL pbCancel,
DWORD dwCopyFlags
);
Parameters
I searched these forums for CopyFileEx and I really think there is some help there. Did you look in the CodeGuru articles?
Well...what I want to know (and probably see) is where you actually call the function 'CopyFile()'. You have a modal dialog opened with a progress bar...thus, I am assuming that the function will be called somewhere within this modal dialog...and in order to determine exactly why you are having problems with updating your progress bar...Quote:
Originally posted by jkw2068
Not sure what is meant by this. Could you explain please?
I believe his problem is that if for example, he has 1mb worth of files to copy and one of the files is 800k he sits for a minute while it copies then gets an 80% jump on his progress bar. He needs to be able to increment the progress bar smoothly, which will require feedback from whatever method he uses to copy the file. CopyFileEx will provide that feedback, or he could write his own copy function pretty easily too. Combine the feedback with a PeekMessage, DispatchMessage call and he'll be there. No need for threads.Quote:
Originally posted by Andreas Masur
Well...what I want to know (and probably see) is where you actually call the function 'CopyFile()'. You have a modal dialog opened with a progress bar...thus, I am assuming that the function will be called somewhere within this modal dialog...and in order to determine exactly why you are having problems with updating your progress bar...
Yes...that is what I basically assume as well...and that is why I would like to see the actual code and where it is placed at the moment... :cool:Quote:
Originally posted by GCDEF
I believe his problem is that if for example, he has 1mb worth of files to copy and one of the files is 800k he sits for a minute while it copies then gets an 80% jump on his progress bar. He needs to be able to increment the progress bar smoothly, which will require feedback from whatever method he uses to copy the file. CopyFileEx will provide that feedback, or he could write his own copy function pretty easily too. Combine the feedback with a PeekMessage, DispatchMessage call and he'll be there. No need for threads.
Here ya go.
[CODE]
void CCopyDlg::CopyProgress(void)
{
//
m_progress.SetPos(m_progress.GetPos() + 30);
int copy = CopyFile(m_strFILELOCATION,"A:\\" + m_strFILENAME,FALSE); \\Copying file
if(copy > 0){
m_progress.SetPos(m_progress.GetPos() + 60);
CStdioFile csf;
csf.Open("a:\\autoexec.bat", CFile::modeWrite | CFile::modeCreate | CFile::typeText);
\\Need to handle on error for file creation\write.
m_progress.SetPos(m_progress.GetPos() + 90);
csf.WriteString(m_strFILENAME);
csf.Close();
m_progress.SetPos(m_progress.GetPos() + 100);
MessageBox("Disk is ready for use", "Done", MB_OK | MB_ICONINFORMATION);
OnCancel();
}
else {
m_progress.SetPos(m_progress.GetPos() + 100);
MessageBox("Unable to copy the file " + m_strFILENAME, "ERROR", MB_OK | MB_ICONERROR);
OnCancel();
}
}CODE]
Thank you....okay this is a regular function of your second (modal) dialog. As long as you are within this function the message queue of that dialog will not be processed. In other words, your progress bar will not be updated...
Since you are updating your progress bar based on some other tasks that you are doing and not only on the copying of the file alone, using 'CopyFileEx()' will not help here much. So, I would suggest that you update the progress bar itself after setting the new position...thus
Code:void CCopyDlg::CopyProgress(void)
{
m_progress.SetPos(m_progress.GetPos() + 30);
m_progress.UpdateWindow();
int copy = CopyFile(m_strFILELOCATION,"A:\\" + m_strFILENAME,FALSE); \\Copying file
if(copy > 0)
{
m_progress.SetPos(m_progress.GetPos() + 60);
m_progress.UpdateWindow();
CStdioFile csf;
csf.Open("a:\\autoexec.bat", CFile::modeWrite | CFile::modeCreate | CFile::typeText);
// Need to handle on error for file creation\write.
m_progress.SetPos(m_progress.GetPos() + 90);
m_progress.UpdateWindow();
csf.WriteString(m_strFILENAME);
csf.Close();
m_progress.SetPos(m_progress.GetPos() + 100);
m_progress.UpdateWindow();
MessageBox("Disk is ready for use", "Done", MB_OK | MB_ICONINFORMATION);
}
else
{
m_progress.SetPos(m_progress.GetPos() + 100);
m_progress.UpdateWindow();
MessageBox("Unable to copy the file " + m_strFILENAME, "ERROR", MB_OK | MB_ICONERROR);
}
}
Hello guys....I'm a niewbie in coding and i'd like some help....
Is there a demo of copying some files from a location to another displaying also the copying progress in a progress bar?
I m using VC++ Studio 6
Please help me by posting a zip or a link to a FULL tutorial....
Regards
People that answer questions usually prefer that we look for answers first. Did you look in the articles in the CodeGuru web site and other such web sites? Also, it is usually better to create your own thread rather than adding to someone else's. Using someone else's is often called "hijacking".
SHFileOperation()Quote:
Originally Posted by BorBoMoTSaLo
ok this nethod is called highjacking but i 'd like to learn how can i make my dialog act like this.....
So is there a link for a simple demo project that copies a file (not counting) from a location to another to help me finish my work?
I m not an expert and i m not going to be....I just want to add progress bar in
my personal program.....
Thanks a lot again
Regards
But if you are inconsiderate to the people you want to help you will get little or no help.Quote:
Originally Posted by BorBoMoTSaLo
You don't need to be an expert programmer to be considerate.Quote:
Originally Posted by BorBoMoTSaLo
@Sam Hobbs
Sorry for the annoyance but i trying to find a solution for 2 days.....
At this time i have nowhere to look searh or something.....I'm just asking for a way to create a realtime progress bar....
In the beginning is only copy & paste.....Then knowledge rises and you can share it with people that need it....
I think its very easy for you to create a demo project that does the above work,but for me isn't....
Everybody was a niewbie at the beginning and i think you know how it feels...
I'd be thankfull if you could attach a zip file including the workspase of the above program....
thanks again and i m sorry for the annoyance....
Regards
You are inconsiderate because you refuse to start a new thread.
You are inconsiderate if you have not looked in the CodeGuru web site and other such sites for relevant articles.
You are inconsiderate if you ignored Andreas's answer.
Even if you did start your own thread, it is unlikely you will get much help if you ask others to do all your work for you. If you don't know how to use SHFileOperation() or anything in an article, then look at it (SHFileOperation or the article) and do the best you can to figure out how to use it. Then ask specific questions. Do that in another thread, not here.