Where to put KillTimer() in Dialog

[rcode]

Where is the best place to put the KillTimer()? DestroyWindow or PostNcDestroy()? Will those functions always get called? Someone told me that DestroyWindow() never gets called, which seemed wierd.

[Abdul Kareem]

You can put it in the Destructor function of the dialog class.

~Kareem~

--------------------------------------------
If it is useful to you, you can rate it.....

[Kaiserle2000]

Are you sure?
When I put it into the destructor of a modal dialog, I get an assertion failed when I close the window before timer expired.
Exact error:
Assertion failed in afxwin2.inl row: 181
In this line I see:
_AFXWIN_INLINE CWnd* CWnd::SetActiveWindow()


Someone an idea? Thanks a lot.

[Hobson]

You cannot put it in destructor, because timer is a resource associated with window, and at the time destructor is execited, window is already destroyed. You should create a handler for WM_DESTROY message and kill timer there.

Cheers,
Hob

[Skizmo]

Put it in the WM_DESTROY message. . before the CDialog:estroy () is called.

[humptydumpty]

Simply handle WM_CLOSE Function in your Code and write the Code in your OnClose() method.Because WM_CLOSE internally call DestroyWindow Function to DestroyWindow.

Thanx

[Skizmo]

WM_CLOSE is only called when you use the close button from your systemmenu of your mainwindow.

[humptydumpty]

WM_CLOSE is only called when you use the close button from your systemmenu of your mainwindow.

what else you are expecting .and how you are going to close the app

Thanx

[Skizmo]

what else you are expecting .and how you are going to close the app

Thanx

Closing the app. can be done in more then 1 way. For example. . if you don't catch the escape-button. .. it closes the app when you press escape, without sending a WM_CLOSE. Or. .if you have your own 'Close/Exit' button on a Dialog, you can do a 'EndModalLoop ()' and the also the WM_CLOSE is not send.

The WM_DESTROY is always send, because no matter how to close your app. it must always destroy it's resources.

[Pravin Kumar]

Hello,

WM_DESTROY handler is the best place to kill the timer. WM_CLOSE handler is not the proper option since the dialog can be closed without getting WM_CLOSE message sent (like closing with OK or Cancel key). Destructor of the dialog class also is not the proper place since the destructor is called after the window is dismissed with and the timer is associated with the window. That is why an assertion failure occured.

Regards,
Pravin.