int to string

[nigelhoath]

Just wondered if I have missed something and if the following code could be more elegant?
I'm hunting through a network trace. Each row is in s_current_row. If I find one of the searchstrings (could be multiple occurrences of each searchstring) stored in array searchstring[x] then I replace it with some values including the integer that is the index of the searchstring.

Any thoughts for still a newbie very welcome, Nigel

	// loop through search strings
	          	int result;
	          	for (int x = 1; x <= countdef; x++)
	          	{
	          		while ((result = s_current_row.find(searchstring[x], 0)) != -1)
	          		{
		          		string temp = "***";
      				stringstream out;
				out << x;
				temp += out.str();
				temp += "|";
		          		temp += database[x];
		          		temp += "|";
		          		temp += field[x];
		          		temp += "***";
		          		s_current_row.replace( result, searchstring[x].size(), temp );
		          	}
		          		
	          	}

[Speedo]

You could use boost::lexical_cast to save a few lines

string temp("***" + boost::lexical_cast<string>(x) + "|");
temp += database[x];
// etc

But unless you're needing to do quite a few conversions or already have a dependecy on boost, I don't think I'd bother.

On a side note, in your while statement you should really compare the find result to string::npos instead of -1.

[nigelhoath]

speedo: I haven't checked out boost yet and as this stuff is compiled on lots of different environs I want to stay as clean (traditional - standard) as I can.

Yes - I can see -1 is a potential pitfall.

Gracias Amigo

[laserlight]

Incidentally, it might be better to do this instead:

stringstream out;
out << "***" << x << "|" << database[x] << "|" << field[x] << "***";
s_current_row.replace( result, searchstring[x].size(), out.str() );