Caesar cipher

[hitman_38]

Hi everyone
I have been trying to create a simple encryption program it will read the txt from a .txt and then if plaintext encrypt it or if encrypted decrypt it to plaintext using the caesar's cipher I just can't get my head around as I am only new to c++ programming

Any help or ideas would be great

Here's what I have so far:

#include <iostream>//for input and output
#include <fstream>// for working with files

#define isupper(a) ((a)>= 'A' && (a)<= 'Z') 
#define islower(a) ((a)>= 'a' && (a)<= 'z') 

using namespace std;
ifstream inFile;
ofstream outFile;
char PlainText[100], CipherText[100] ;
int main() 
{
    {
       outFile.open("test.txt");
       (!outFile.eof() << PlainText[100]);
       for ( int i = 0 ; PlainText[i] ; i++ )
       {
           if ( isupper(PlainText[i]) )
            CipherText[i] = 25 - (PlainText[i] - 'A') + 'A' ;
           else if ( islower(PlainText[i]) )
            CipherText[i] = 25 - (PlainText[i] - 'a') + 'a' ;
           else CipherText[i] = PlainText[i] ;
        }
       outFile << CipherText << endl;
    }
inFile.close();
system("pause");
return 0;
}

Thanks in advance

[Odiee]

Don't know much about Ceasar cipher, but please read this before posting.
Also you can edit your post according to that.
http://www.codeguru.com/forum/announ...nouncementid=6

[hoxsiew]

You should use code tags to make it easier to follow your code. See Odiee's link for info on how to do that.

From a casual glance at your code, it appears that there are several problems. inFile is never opened nor read from. PlainText and CipherText are never initialized. This line:

(!outFile.eof() << PlainText[100]);

appears to be missing something; perhaps a while or if. It may be that it is misplaced and should be a few lines up (as indicated by the superfluous opening '{' ).

The loop for your actual encryption/decryption looks sound.

[hitman_38]

Ok I see the mistakes that are there but I not sure how to fix them. I'm still learn. I added some comments if that will help.
I know the encryption/decryption part works fine with cin & cout's, but I'm just confused about reading & writing to a text file instead of the cin & cout's?

#include <iostream>//for input and output
#include <fstream>// for working with files

#define isupper(a) ((a)>= 'A' && (a)<= 'Z') 
#define islower(a) ((a)>= 'a' && (a)<= 'z') 

using namespace std;

ifstream inFile;//file handle for data writing
ofstream outFile;//file handle for data reading
char PlainText[100], CipherText[100] ;

int main() 
{
   cout << "A program that encrypt/decrypt's text files" << endl << endl;
   cout << "Now encrypting/decrypting ..." << endl << endl;
    {
       //open file
       outFile.open("test.txt");
       if (!outFile.eof() << PlainText[100]);
       for ( int i = 0 ; PlainText[i] ; i++ )
       {
           if ( isupper(PlainText[i]) )//run encrypt/decrypt
            CipherText[i] = 25 - (PlainText[i] - 'A') + 'A' ;
           else if ( islower(PlainText[i]) )
            CipherText[i] = 25 - (PlainText[i] - 'a') + 'a' ;
           else CipherText[i] = PlainText[i] ;
        }
       //write to file
       outFile << CipherText << endl;
    }
//close file
outFile.close();
system("pause");
return 0;
}

[hoxsiew]

You're still not using inFile at all. Is it supposed to be the input text? Immediately after you open outFile, your sending your PlainText buffer to it thereby overwriting anything in the file. Are you supposed to be reading PlainText from outFile? Try:

  outFile >> PlainText;

but I suspect you really want to read it from inFile.

[hitman_38]

I'm not sure where or how to use the infile. It is meant to open the file with outfile read it to the Plaintext buffer then it goes through the encryption/decryption changing to CipherText then write to the file.

I tried

outFile >> PlainText;

But it gives me an error
expected '(' before "outfile"
am I suppose to use this instead of

(!outFile.eof() << PlainText[100]);

[hitman_38]

I have uploaded the .cpp file if that will help. I am completely stumped on what to do to make this program work

[Martin O]

Sounds like you need to learn how to do simple file reading & writing--forget about encryption for now. First try to write a simple program that reads text from one file then writes that text to another file. If you have problems with that, post it here. Since it is a simpler problem of basic file read/write, you should be able to post it using code tags as opposed to an attachment. More people will bother to help if they don't have to download something.

[Timothyk]

I too have the very problemof c++ caesar encryption.
Can any one pliz just give me a sample working code with illustrations on how they work?

[hoxsiew]

What are you having trouble with? The cipher itself, or the file I/O associated with plaintext to ciphertext files?

[lio_cs]

maybe this site will help you for file access (read / write )

http://www.cplusplus.com/doc/tutorial/files/