Adding an item to an existing CMenu

[Anarchi]

VS2005 C++ MFC

When I try to add a new Menu Item to an existing Menu, the new item never shows up. All I see are the existing menu items from the Resource.

    

    // Load SysTrayMenu (WORKS OK, IDR_MENU1 is a Menu Resource with five items)
    if(SysTrayMenu.LoadMenu(IDR_MENU1)==NULL) AfxMessageBox("LoadMenu Failed");


    // Add a new item to the existing menu (FAILS)
    MENUITEMINFO MenuItem;
    ZeroMemory(&MenuItem, sizeof(MENUITEMINFO));
    MenuItem.cbSize = sizeof(MENUITEMINFO);
    MenuItem.fMask = MIIM_TYPE|MIIM_ID|MIIM_STATE;  //MIIM_STRING|MIIM_ID;
    MenuItem.wID = ID_POPUP_ADMIN;
    MenuItem.fType = MFT_STRING;
    MenuItem.fState = MFS_ENABLED;
    MenuItem.cch = 6;
    MenuItem.dwTypeData = "Admin";
    SysTrayMenu.InsertMenuItem(3, &MenuItem, TRUE);

	


    // Lets try again. Add a new item to the existing menu (FAILS AS WELL)
    SysTrayMenu.InsertMenu(4, MF_STRING|MF_BYPOSITION|MF_ENABLED, ID_POPUP_ADMIN, "Admin");

    // Has a migraine... lets try again (FAILS AS WELL)
    SysTrayMenu.AppendMenu(MF_BYPOSITION, ID_POPUP_ADMIN, "Admin");
	
    // Apparently we need to call this to redraw the menu
    DrawMenuBar();

Any ideas?

[cilu]

And what is SysTrayMenu?

[Anarchi]

Its a standard CMenu.

CMenu SysTrayMenu;

[VictorN]

Its a standard CMenu.

CMenu SysTrayMenu;

So where is it declared and how is it used after LoadMenu/InsertMenu?

[Anarchi]

The CMenu is declared as a member in the main MFC Dialog class.

The menu is activated when right-clicking the system tray icon.

I use the CSysTrayIcon Class made by Prateek Kaul, found here:
http://www.codeguru.com/Cpp/misc/mis...int.php/c3891/

To popup the menu, I handle WM_SYSTRAYMSG in PreTranslateMessage and call:
SysTrayIcon.OnContextMenu(SysTrayMenu.GetSubMenu(0), ptMouse, this);

The above function contains:

BOOL CSysTrayIcon::OnContextMenu(CMenu* pContextMenu, CPoint ptMouse, CWnd* pWndMessageHandler)
{
    // The window is brought forward, so that it starts 
    // receving messages, rather than currently active window.
    // If we don't do this the messages of the context menu will
    // go to the currently active window.
    pWndMessageHandler->SetForegroundWindow();
	
    BOOL bResult = pContextMenu->TrackPopupMenu(
                       TPM_LEFTALIGN | TPM_RIGHTBUTTON, 
                       ptMouse.x, 
                       ptMouse.y, 
                       pWndMessageHandler
                   );
    
    return bResult;
}

Do you think that System Tray Icon class may not be handling the menu modification properly?

Maybe I should try adding "DrawMenuBar()" to that function, rather than calling DrawMenuBar in InitDialog()

[Anarchi]

I added the below line in that systemtrayicon class, but it didnt make a difference.
:rawMenuBar(AfxGetMainWnd()->m_hWnd);

By the way, when I call InsertMenuItem() in the main InitDialog function, its return value is successful.

[Igor Vartanov]

SysTrayMenu.InsertMenuItem(3, &MenuItem, TRUE);
. . .
To popup the menu, I handle WM_SYSTRAYMSG in PreTranslateMessage and call:
SysTrayIcon.OnContextMenu(SysTrayMenu.GetSubMenu(0), ptMouse, this);

Don't you see any problem with such insertion and further use?

[Anarchi]

Don't you see any problem with such insertion and further use?

Interesting, why is that "GetSubItem" Thanks I'll look into it.

[VictorN]

Interesting, why is that "GetSubItem" Thanks I'll look into it.

Where do you see (or have) GetSubItem?
I don't see any...

Besides, you don't need to call DrawMenuBar.

[Anarchi]

Sorry I meant "GetSubMenu(0)"

I still haven't figured it out, maybe I'll just work around the problem and add a hotkey or something.

[Igor Vartanov]

You definitely need do some reading on menus in Windows.

What they used to call a popup menu is a submenu in fact.
Now, you show submenu 0 but add new menu item to the parent menu. So once again, don't you see any problem with this?

[Anarchi]

I'm confused, so do I need to add the new item to the submenu? (instead of the parent menu)

Why do Microsoft make things so complicated lol

[VictorN]

,,, Why do Microsoft make things so complicated lol

Well where did you see less "complicated" menus?

[Igor Vartanov]

I'm confused, so do I need to add the new item to the submenu? (instead of the parent menu)

If I were you, I would already be re-reading MSDN and have made twenty tries instead of a doubtful asking here.

Why do Microsoft make things so complicated lol

Sorry, but complicated it looks only because of your lack of experience. Again, if I were you, I would withhold from judging something I do not completely understand.

[Anarchi]

Thanks for the help Igor.

I haven't had time to try again (very busy at work ) but I'll have another read of MSDN when I get a chance.

With a lot of Microsoft coding, you need to spend a huge amount of time understand it properly
They should KISS (keep it simple silly) or at least provide wrappers to simplify common tasks like they do in Visual Basic.