Why this small code snippet gives runtime error?

[forumuser11@gmail.com]

#include <iostream>
using namespace std;

class A
{
  int* ptr;

public:
	A(int* i)
	{
                 ptr=new int;
	  ptr=i;
	}
	A& operator=(A &x)
	{
	  if(this==&x)
	  {
		  return *this;
	  }
	  else
	  {
		  delete this->ptr;
		  this->ptr=0;
		  this->ptr=new int;
		  this->ptr=x.ptr;
	  }
		  return *this;
	}
	void show()
	{
	  cout<<*ptr;
	}
	~A()
	{
		cout<<"Inside ~A()"<<endl;
		if(ptr!=0)
			delete this->ptr;  //ERROR CASUSES HERE
		this->ptr=0;
	}
};
int main()
{
	int* i=new int;
	int* j=new int;
	*i=10;
	*j=20;

	A a1(i);
	A a2(j);

	a1=a2;
	
	a1.show();
    
}

Output:
20
Inside ~A()
Inside ~A()
RUNTIME EROOR

[ninja9578]

A(int* i)
{
     ptr=new int;
     ptr=i;
}

Well you're leaking memory here.

If you'll use code tags I'm sure that the fact that you're copying the object is causing a double delete.

[monarch_dodra]

#include <iostream>
using namespace std;

class A
{
  int* ptr;

public:
    A(int* i)
    {
        ptr=new int;
        *ptr=*i;
    }
    A& operator=(A &x)
    {
      if(this==&x)
      {
          return *this;
      }
      else
      {
          delete this->ptr;
          this->ptr=0;
          this->ptr=new int;
         *(this->ptr)=*(x.ptr);
      }
          return *this;
    }
    void show()
    {
      cout<<*ptr;
    }
    ~A()
    {
        cout<<"Inside ~A()"<<endl;
        if(ptr!=0)
            delete this->ptr;  //ERROR CASUSES HERE
        this->ptr=0;
    }
};
int main()
{
    int* i=new int;
    int* j=new int;
    *i=10;
    *j=20;

    A a1(i);
    A a2(j);

    a1=a2;
    
    a1.show();
    
}

Output:
20
Inside ~A()
Inside ~A()
RUNTIME EROOR

Remember you need to deference your pointers, to copy the values they point to, rather than copy the actual pointers.

Off topic: Don't you know how to use code tags by now?...

[Paul McKenzie]

</code>

You should have seen that this does not work for code tags. Do you not read your own posts?

[code] Your code goes here [/code]

Regards,

Paul McKenzie