List and Arrays

[user612345]

This might be a silly question but how do you properly compensate for List Counts and Array Size?

For example Lists and Array start at 0, but if I want to loop through them I need to -1 off the Count/Length or else I will get an out of bounds condition, is this a proper way of coding?

You can see my code below.

            List<string> introMessage = new List<string>();

            using (StreamReader introRead = new StreamReader("intro.txt"))
            {
                string line;
                while ((line = introRead.ReadLine()) != null)
                {
                    introMessage.Add(line);
                }
            }
            for (int x = 0; x <= introMessage.Count-1; x++)
            {
                Console.WriteLine(introMessage[x]);
            }

[BigEd781]

No, you are doing it wrong (well, maybe not wrong. It does work, it is just unconventional and unnecessary). You are using <=, when you need only use <.

for( int i = 0; i < someArray.Length; ++i )
{
    // do stuff
}

However, arrays and generic collections implement IEnumerable, so just use a foreach statement instead:

foreach( int i in someArrayOfInts )
{
    // do stuff
}

[Arjay]

As Ed mentioned...

for (int x = 0; x < introMessage.Count; x++)
{
  Console.WriteLine(introMessage[x]);
}

or using foreach...

foreach ( var line in introMessage )
{
  Console.WriteLine( line );
}

In general, prefer using foreach over for.

[user612345]

I didn't know about foreach but I am definitely using that from now on.

Once again excellent responses from this forum.