IDispose Best Practices...

[elitelogic]

I've searched for info, but I'm still confused. What is the best practice for Dispose() in this scenario and why?

(And what are the code tags? doesn't seem to work.

    class LineReader : ILineReader // derived from IDispose
    {
        StreamReader _file;
        bool _eof = false;

        public LineReader(ref string fileName)
        {
            _file = new StreamReader(fileName);
        }

        // Interface implementation
        public bool AtEof { get { return _eof; } }

        public String ReadNextLine()
        {
            string line = null;

            try
            {
                if (_file.Peek() >= 0)
                {
                    line = _file.ReadLine();
                }
                else
                {
                    _eof = true;
                }
            }
            catch (Exception e)
            {
                Console.WriteLine("ReadNextLine() exception: " + e.Message);
            }

            return line;
        }

        // For IDisposable
        public void Dispose()
        {
            // What is best practice?
        }
    }

[Arjay]

You can read up on it by searching bing or google for "Idisposable pattern msdn".

A great article on it is "Digging into IDisposable" in MSDN magazine. http://msdn.microsoft.com/en-us/magazine/cc163392.aspx

This article refers to a Joe Duffy article: "IDisposable guidelines".
http://www.bluebytesoftware.com/blog...3-20c06ae539ae

[BigEd781]

You just need to call Dispose() on all of your fields that implement IDisposable. So, in your case, you would have:

public void Dispose()
{
    _file.Dispose();
}