-
December 11th, 2010, 03:02 PM
#1
Dispose of WPF Window
Hello, I have a WPF Window that I show with Window.Show(). When I click X the form closes. But it is still in memory and the GC never comes and cleans it up. Also I do not have any refrences/handles to it.
does any one know what could be causing it to stay in memory?
Thanks!
I am using the following code with the window:
Code:
Public Class PageWindow
Implements System.IDisposable
Public UserPressedExit As Boolean
Dim MainWin As MainWindow
Private _IsBuddy As Boolean
Private _IsBlocked As Boolean
Private _IsOnline As Boolean
Public Property FirstOpen As Boolean
Public Property IsOnline As Boolean
Get
Return _IsOnline
End Get
Set(ByVal value As Boolean)
If _IsOnline <> value Then
_IsOnline = value
End If
End Set
End Property
Public Property IsBuddy As Boolean
Get
Return _IsBuddy
End Get
Set(ByVal value As Boolean)
If _IsBuddy <> value Then
_IsBuddy = value
End If
End Set
End Property
Private Sub Window_Loaded(ByVal sender As System.Object, ByVal e As System.Windows.RoutedEventArgs)
MainWin = CType(Application.Current.Windows(0), MainWindow)
End Sub
Private Sub Window_Closed(ByVal sender As System.Object, ByVal e As System.EventArgs)
Me.Dispose()
End Sub
Private Sub txtTitle_PreviewMouseDown(ByVal sender As System.Object, ByVal e As System.Windows.Input.MouseButtonEventArgs)
Me.DragMove()
End Sub
Private Sub pbMin_PreviewMouseUp(ByVal sender As System.Object, ByVal e As System.Windows.Input.MouseButtonEventArgs)
WindowState = Windows.WindowState.Minimized
End Sub
Private Sub pbClose_PreviewMouseUp(ByVal sender As System.Object, ByVal e As System.Windows.Input.MouseButtonEventArgs)
UserPressedExit = True
txtChat.Clear()
Me.Close()
End Sub
Private Sub txtSend_KeyUp(ByVal sender As System.Object, ByVal e As System.Windows.Input.KeyEventArgs)
If e.Key = Key.Enter Then
btnSend_Click(Nothing, Nothing)
End If
End Sub
Private Sub btnSend_Click(ByVal sender As System.Object, ByVal e As System.Windows.RoutedEventArgs)
If String.IsNullOrWhiteSpace(txtSend.Text) Then
MessageBox.Show("Empty Message.")
txtSend.Text = ""
Else
Send(txtSend.Text)
txtSend.Text = ""
End If
End Sub
Public Sub Page(ByVal message As String)
If String.IsNullOrEmpty(message) = False Then
If MainWin.Settings.ShowPageTimestamp Then
txtChat.AppendText(Me.Tag.ToString() & " (" & Format(Date.Now, "HH:mm:ss") & "): " & message & Environment.NewLine)
Else
txtChat.AppendText(Me.Tag.ToString() & ": " & message & Environment.NewLine)
End If
End If
End Sub
Private Sub Send(ByVal text As String)
'work on 389 event
MainWin.Send("PAGE " + Me.Tag.ToString + " " + text)
If MainWin.Settings.ShowPageTimestamp Then
txtChat.AppendText(MainWin.Settings.Nick & ": " & text & Environment.NewLine)
Else
txtChat.AppendText(MainWin.Settings.Nick & " (" & Format(Date.Now, "HH:mm:ss") & "): " & text & Environment.NewLine)
End If
End Sub
#Region "IDisposable Support"
Private disposed As Boolean ' To detect redundant calls
' This code added by Visual Basic to correctly implement the disposable pattern.
Public Sub Dispose() Implements IDisposable.Dispose
' Do not change this code. Put cleanup code in Dispose(ByVal disposing As Boolean) above.
Dispose(True)
GC.SuppressFinalize(Me)
End Sub
Protected Overridable Sub Dispose(ByVal disposing As Boolean)
If Not Me.disposed Then
If disposing Then
'dispose managed state (managed objects).
RemoveHandler Me.Loaded, AddressOf Window_Loaded
RemoveHandler txtTitle.PreviewMouseDown, AddressOf txtTitle_PreviewMouseDown
RemoveHandler pbMin.PreviewMouseUp, AddressOf pbMin_PreviewMouseUp
RemoveHandler pbClose.PreviewMouseUp, AddressOf pbClose_PreviewMouseUp
RemoveHandler txtSend.KeyUp, AddressOf txtSend_KeyUp
RemoveHandler btnSend.Click, AddressOf btnSend_Click
RemoveHandler Me.Closed, AddressOf Window_Closed
BindingOperations.ClearBinding(txtTitle, TextBlock.TextProperty)
Me.Icon = Nothing
pbMin = Nothing
pbClose = Nothing
MainWin = Nothing
Me.Resources.Clear()
GC.Collect()
End If
End If
Me.disposed = True
End Sub
Protected Overrides Sub Finalize()
' Do not change this code. Put cleanup code in Dispose(ByVal disposing As Boolean) above.
Dispose(False)
MyBase.Finalize()
End Sub
#End Region
End Class
Code:
<Window x:Class="PageWindow"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Title="PageWindow" Height="300" Width="400"
Icon="Images\R2.ico" WindowStyle="None" ResizeMode="NoResize"
WindowStartupLocation="Manual" Loaded="Window_Loaded"
BorderThickness="2" BorderBrush="#FFAE28"
Closed="Window_Closed">
<Window.Resources>
<Style x:Key="sRenegadeButton" TargetType="Button">
<Setter Property="FontFamily" Value="Franklin Gothic Medium" />
<Setter Property="FontSize" Value="12px" />
<Setter Property="FontWeight" Value="Bold" />
<Setter Property="Background" Value="Transparent" />
<Setter Property="Foreground" Value="#FFAE28" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
<Border Name="Border" BorderBrush="#FFAE28" BorderThickness="1" CornerRadius="3"
Background="{TemplateBinding Background}" SnapsToDevicePixels="True">
<Border Name="innerborder" BorderBrush="#FFAE28" BorderThickness="1" CornerRadius="3"
Background="{TemplateBinding Background}" SnapsToDevicePixels="True" Margin="1">
<ContentPresenter HorizontalAlignment="Center" VerticalAlignment="Center" Name="content" />
</Border>
</Border>
<ControlTemplate.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter TargetName="Border" Property="BorderBrush" Value="#FFD528" />
<Setter TargetName="innerborder" Property="BorderBrush" Value="#FFD528" />
<Setter Property="Background" Value="#28FFAE28" />
<Setter Property="Foreground" Value="#FFD528" />
</Trigger>
<Trigger Property="IsPressed" Value="True">
<Setter Property="Background" Value="#28FFAE28" />
<Setter TargetName="content" Property="RenderTransform" >
<Setter.Value>
<TranslateTransform Y="1.0" />
</Setter.Value>
</Setter>
</Trigger>
<Trigger Property="IsEnabled" Value="False">
<Setter TargetName="Border" Property="BorderBrush" Value="#80E6A023" />
<Setter TargetName="innerborder" Property="BorderBrush" Value="#80E6A023" />
<Setter Property="Foreground" Value="#8CFFD528" />
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
<Style x:Key="sRenegadeTextBox" TargetType="TextBox">
<Setter Property="FontFamily" Value="Franklin Gothic Medium" />
<Setter Property="FontSize" Value="12px" />
<Setter Property="Foreground" Value="#FFD528" />
<Setter Property="Background" Value="#28FFAE28" />
<Setter Property="BorderBrush" Value="#FFAE28" />
<Setter Property="CaretBrush" Value="#FFAE28" />
<Setter Property="SelectionBrush" Value="#FFD528" />
<Setter Property="BorderThickness" Value="1" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="TextBox">
<Border Name="Bd" BorderThickness="{TemplateBinding BorderThickness}"
BorderBrush="{TemplateBinding BorderBrush}"
Background="{TemplateBinding Background}" SnapsToDevicePixels="true">
<ScrollViewer Name="PART_ContentHost" Background="{TemplateBinding Background}"
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
</Border>
<ControlTemplate.Triggers>
<Trigger Property="IsEnabled" Value="False">
<Setter Property="Foreground" Value="#8CFFD528" />
<Setter Property="Background" Value="#1EFFAE28" />
<Setter Property="BorderBrush" Value="#80E6A023" />
<Setter TargetName="PART_ContentHost" Property="Background" Value="#1EFFAE28"/>
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
</Window.Resources>
<Grid>
<Grid.RowDefinitions>
<RowDefinition Height="21" />
<RowDefinition Height="32" />
<RowDefinition Height="*" />
<RowDefinition Height="27" />
</Grid.RowDefinitions>
<Grid.Background>
<ImageBrush x:Name="ibBackground" ImageSource="Images\page_back.gif" />
</Grid.Background>
<Border Grid.Row="0" BorderBrush="#FFAE28" BorderThickness="0,0,0,2"
SnapsToDevicePixels="True" />
<Grid Name="gTitleBar" Grid.Row="0" Background="#32FFAE28">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*" />
<ColumnDefinition Width="30" />
<ColumnDefinition Width="32" />
</Grid.ColumnDefinitions>
<TextBlock Name="txtTitle" Grid.Column="0" Text="{Binding Title,RelativeSource={RelativeSource FindAncestor,AncestorType=Window}}"
HorizontalAlignment="Stretch" VerticalAlignment="Center"
TextAlignment="Left" Margin="4,0,1,0"
PreviewMouseDown="txtTitle_PreviewMouseDown"
Foreground="#FED528" FontFamily="Franklin Gothic Medium" />
<Image Name="pbMin" Grid.Column="1" Width="28" Height="15"
HorizontalAlignment="Center" VerticalAlignment="Center"
PreviewMouseUp="pbMin_PreviewMouseUp" Stretch="None">
<Image.Style>
<Style TargetType="{x:Type Image}">
<Setter Property="Source" Value="Images\min.png" />
<Style.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter Property="Source" Value="Images\min_o.png" />
</Trigger>
</Style.Triggers>
</Style>
</Image.Style>
</Image>
<Image Name="pbClose" Grid.Column="2" Width="28" Height="15"
HorizontalAlignment="Left" VerticalAlignment="Center"
PreviewMouseUp="pbClose_PreviewMouseUp" Stretch="None">
<Image.Style>
<Style TargetType="{x:Type Image}">
<Setter Property="Source" Value="Images\close2.png" />
<Style.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter Property="Source" Value="Images\close2_o.png" />
</Trigger>
</Style.Triggers>
</Style>
</Image.Style>
</Image>
</Grid>
<Grid Grid.Row="1">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*" />
<ColumnDefinition Width="25" />
<ColumnDefinition Width="25" />
<ColumnDefinition Width="25" />
<ColumnDefinition Width="*" />
</Grid.ColumnDefinitions>
<!--<Button Name="btnAddBuddy" Grid.Column="1" Margin="0,2,0,0">
<Button.Style>
<Style TargetType="{x:Type Button}">
<Setter Property="Background" Value="Transparent" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="{x:Type Button}">
<Grid>
<Border Name="Border" BorderBrush="Transparent" BorderThickness="1" CornerRadius="3"
Background="{TemplateBinding Background}" SnapsToDevicePixels="True">
</Border>
<Image Name="iAddBuddy" Margin="1" Source="Images\Add Buddy 32x36.png" />
<Image Name="iAddBuddyDissabled" Margin="1" Source="Images\Add Buddy 32x36.png" Visibility="Hidden" />
</Grid>
<ControlTemplate.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter TargetName="Border" Property="BorderBrush" Value="#FFD528" />
</Trigger>
<Trigger Property="IsPressed" Value="True">
<Setter Property="Background" Value="#FFD528" />
</Trigger>
<Trigger Property="IsEnabled" Value="False">
<Setter TargetName="Border" Property="BorderBrush" Value="Transparent" />
<Setter TargetName="iAddBuddy" Property="Visibility" Value="Hidden" />
<Setter TargetName="iAddBuddyDissabled" Property="Visibility" Value="Visible" />
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
</Button.Style>
</Button>
<Border Name="bDeleteBuddyBorder" Grid.Column="2" BorderThickness="1"
SnapsToDevicePixels="True" Margin="0,2,0,0">
<Image Name="iDeleteBuddy" Margin="1" IsEnabled="True"
Source="Images\Delete 32x32.png">
<Image.Style>
<Style TargetType="{x:Type Image}">
<Style.Triggers>
<Trigger Property="IsEnabled" Value="False">
<Setter Property="Source" Value="Images\Delete Disabled 32x32.png" />
</Trigger>
</Style.Triggers>
</Style>
</Image.Style>
</Image>
<Border.Style>
<Style TargetType="Border">
<Setter Property="BorderBrush" Value="Transparent" />
<Setter Property="Background" Value="Transparent" />
<Style.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter Property="BorderBrush" Value="#FFD528" />
</Trigger>
</Style.Triggers>
</Style>
</Border.Style>
</Border>
<Border Name="bBlockUserBorder" Grid.Column="3" BorderThickness="1"
SnapsToDevicePixels="True" Margin="0,2,0,0">
<Image Name="iBlockUser" Margin="1" IsEnabled="True"
Source="Images\Block Buddy 32x36.png">
<Image.Style>
<Style TargetType="{x:Type Image}">
<Style.Triggers>
<Trigger Property="IsEnabled" Value="False">
<Setter Property="Source" Value="Images\Block Buddy Dissabled 32x36.png" />
</Trigger>
</Style.Triggers>
</Style>
</Image.Style>
</Image>
<Border.Style>
<Style TargetType="Border">
<Setter Property="BorderBrush" Value="Transparent" />
<Setter Property="Background" Value="Transparent" />
<Style.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter Property="BorderBrush" Value="#FFD528" />
</Trigger>
</Style.Triggers>
</Style>
</Border.Style>
</Border>-->
</Grid>
<TextBox Name="txtChat" Grid.Row="2" Margin="4,2,4,2"
Style="{StaticResource sRenegadeTextBox}" UndoLimit="0" />
<Grid Grid.Row="3">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*" />
<ColumnDefinition Width="45" />
</Grid.ColumnDefinitions>
<TextBox Name="txtSend" Grid.Column="0" MaxLength="495"
Height="22" Margin="4,1,2,4" VerticalContentAlignment="Center"
Style="{StaticResource sRenegadeTextBox}" UndoLimit="0"
KeyUp="txtSend_KeyUp" />
<Button Name="btnSend" Content="Send" Grid.Column="1"
Style="{StaticResource sRenegadeButton}"
Height="22" Width="40" Margin="0,1,4,4" Click="btnSend_Click" />
</Grid>
</Grid>
</Window>
-
December 11th, 2010, 04:54 PM
#2
Re: Dispose of WPF Window
GC fires when it wants to, not when you expect it to. You are using Dispose, but not on the right objects
-
December 11th, 2010, 07:14 PM
#3
Re: Dispose of WPF Window
Thanks for your reply,
I have waited 10-20 minutes for the GC with no change. Also could you elaborate a little on the correct way, or correct objects to dispose?
-
December 11th, 2010, 10:12 PM
#4
Re: Dispose of WPF Window
It gets collected as the system gets stuffed. If you create a class, it uses memory the first time it's called. It's memory is used when something ELSE needs it
-
December 12th, 2010, 12:50 AM
#5
Re: Dispose of WPF Window
it appears that if I open 30 windows it increases the memory 30x. and it doesnt go away?
-
December 12th, 2010, 11:35 AM
#6
Re: Dispose of WPF Window
Are you ever setting MainWin to Nothing? Or does it keep spinning up new copies?
-
October 18th, 2012, 12:30 PM
#7
Re: Dispose of WPF Window
Well. I opened and closed a window in my wpf application several times. and each time the memory was increasing until I got the error "Your computer is low on memory. Save files and close these programs: Micoroft Visual Studio 2010".
So GC didn't release the memory.
-
October 18th, 2012, 03:11 PM
#8
Re: Dispose of WPF Window
Post your code, using CODE TAGS, please. Sounds like you need a PROFILER turned on.
Tags for this Thread
Posting Permissions
- You may not post new threads
- You may not post replies
- You may not post attachments
- You may not edit your posts
-
Forum Rules
|
Click Here to Expand Forum to Full Width
|