bad file name or number

[mrbonno]

what im trying to do is make the program check for files if they are there then do the commands and if not send an email it only ever does one if statement and bombs out on any other i get error saying bad filename or number heres my code

WOrks order section
Dim strSpecNameDrwgMF As String
Dim strManvDrwg As String
Dim strDistDrwgMF As String
Dim strSubjectDrwgMF As String
Dim strMsgDrwgMF As String

'******write log file*********
Open "C:/nightlyreports.txt" For Append As #1 ' Open file to read,
Print #1, Now(); "changecont open"
Close #1

strSpecNameDrwgPO = "purvdrwg import specification"
strSpecNameExcepPO = "pur-except import specification"
strPath = "\\Kevingriggs\user\AccessTemp\"
strPurvDrwg = "purvdrwg"
strPurExcept = "purexcept"
strExtn = ".txt"
strExcel = "excel"
strDistDrwgPO = "k.griggs@aim-henshalls.co.uk"
strDistExceptPO = "k.griggs@aim-henshalls.co.uk"
strSubjectDrwgPO = "Parts on Order at incorrect Issue"
strSubjectExceptPO = "Expedite Purchase Order Lines"
StrMsgDrwgPO = "The parts detailed in the attached Excel file are showing a conflict between the part issue and the part issue on the PO. Please check and amend as required"
strMsgExceptPO = "The required dates for the parts detailed in the attached Excel files are sooner than the PO date."
'strDay = Format(Now(), "ddd")
' Works Order Section
strSpecNameDrwgMF = "manvdrwg import specification"
strManvDrwg = "manvdrwg"
strDistDrwgMF = "k.griggs@aim-henshalls.co.uk"
strSubjectDrwgMF = "Works Orders at incorrect issue."
strMsgDrwgMF = "The parts detailed in the attached Excel file are showing a conflict between the part issue and the part issue on the Works Order. Please check and amend as required"
strDistcheck = "k.griggs@aim-henshalls.co.uk"
strsubjectcheck = "ERROR"
strmsgnopurvdrwg = "ChangeCont-2000 was unable to continue due to: File \\Kevingriggs\user\AccessTemp\purvdrwg.txt Not found"
strmsgnopurexcept = "ChangeCont-2000 was unable to continue due to: File \\Kevingriggs\user\AccessTemp\purexcept.txt Not found"
strmsgnopurexcept = "ChangeCont-2000 was unable to continue due to: File \\Kevingriggs\user\AccessTemp\ManvDrwg.txt Not found"

If Dir("\\Kevingriggs\user\AccessTemp\purvdrwg.txt") = "" Then
DoCmd.SendObject acSendNoObject, , , strDistcheck, , , strsubjectcheck, strmsgnopurvdrwg, False
ElseIf Dir("\\kevingrggs\user\accesstemp\purexcept.txt") = "" Then
DoCmd.SendObject acSendNoObject, , , strDistcheck, , , strsubjectcheck, strmsgnopurexcept, False
ElseIf Dir("\\kevingrggs\user\accesstemp\manvdrwg.txt") = "" Then
DoCmd.SendObject acSendNoObject, , , strDistcheck, , , strsubjectcheck, strmsgnoManvDrwg, False
Else
'If strDay = "thu" Then
DoCmd.DeleteObject acTable, strPurvDrwg
DoCmd.TransferText acImportDelim, strSpecNameDrwgPO, strPurvDrwg, strPath & strPurvDrwg & strExtn, True
DoCmd.SendObject acOutputQuery, strPurvDrwg & strExcel, acFormatXLS, strDistDrwgPO, , , strSubjectDrwgPO, StrMsgDrwgPO, False

'******write log file*********
Open "C:/nightlyreports.txt" For Append As #1 ' Open file to read,
Print #1, Now(); "changecont closing"
Close #1

DoCmd.DeleteObject acTable, strPurExcept
DoCmd.TransferText acImportDelim, strSpecNameExcepPO, strPurExcept, strPath & strPurExcept & strExtn, True
DoCmd.SendObject acOutputQuery, strPurExcept & strExcel, acFormatXLS, strDistExceptPO, , , strSubjectExceptPO, strMsgExceptPO, False
'DoCmd.DeleteObject acTable, "manvdrwg_importerrors"
DoCmd.Quit


DoCmd.DeleteObject acTable, strManvDrwg
DoCmd.TransferText acImportDelim, strSpecNameDrwgMF, strManvDrwg, strPath & strManvDrwg & strExtn, True
DoCmd.SendObject acOutputQuery, strManvDrwg & strExcel, acFormatXLS, strDistDrwgMF, , , strSubjectDrwgMF, strMsgDrwgMF, False
DoCmd.Quit
End If
DoCmd.Quit
End Sub

[WoF]

Well, if you really use "C:/nightlyreports.txt" as filename for your log then there is where the program crashes.
You HAVE to use the backslash, so the name must be "C:\nightlyreports.txt". Otherwise your program will crash when opening this nonexisting path.

[mrbonno]

cheers but it crashes on the line after else if?

[mrbonno]

i mean the else if line

[dglienna]

Why would you think this READS a file?

Open "C:/nightlyreports.txt" For Append As #1 ' Open file to read,

[DataMiser]

Why would you think this READS a file?

Open "C:/nightlyreports.txt" For Append As #1 ' Open file to read,

Good question I would expect that line to create a file in the current directory named "C:/nightlyreports.txt" if such file does not already exist or crash.

In no case would it open a file for reading.

As to the error which Else IF are you referring to? From what I can tell in the unformatted code the 2 else if statements look ok.

[d.paulson]

Have you tried removing the slash in

Open "C:/nightlyreports.txt" For Append As #1 ' Open file to read

The slash is a illegal character in a file name hence the error bad file name.

[dglienna]

Because it won't work!

[DataMiser]

btw guys even though the comment says read he is not trying to read from the file. He is just appeneding to it so the mode is ok, comment is wrong but does nothing to the code. / is an issue.

[mrbonno]

yeah im talking about this part

If Dir("\\Kevingriggs\user\AccessTemp\purvdrwg.txt") = "" Then
DoCmd.SendObject acSendNoObject, , , strDistcheck, , , strsubjectcheck, strmsgnopurvdrwg, False
ElseIf Dir("\\kevingrggs\user\accesstemp\purexcept.txt") = "" Then
DoCmd.SendObject acSendNoObject, , , strDistcheck, , , strsubjectcheck, strmsgnopurexcept, False
ElseIf Dir("\\kevingrggs\user\accesstemp\manvdrwg.txt") = "" Then
DoCmd.SendObject acSendNoObject, , , strDistcheck, , , strsubjectcheck, strmsgnoManvDrwg, False
Else

[DataMiser]

Looks like you missed a letter in your path name in the 2 else if statements.
The first one is Kevinriggs but the other two are Kevinrggs.

btw why have you hard coded the path rather than use the variable you defined earlier?

strPath = "\\Kevingriggs\user\AccessTemp\"

I would have used

ElseIf Dir(strPath & "purexcept.txt") = "" Then

[mrbonno]

cheers, this was because i was going back on an old access file created by my boss a while back and i had not seen that string, thanks again!