Out of bounds array problem
CodeGuru Home VC++ / MFC / C++ .NET / C# Visual Basic VB Forums Developer.com
Results 1 to 4 of 4

Thread: Out of bounds array problem

Hybrid View

  1. #1
    Join Date
    Mar 2011
    Posts
    15

    Out of bounds array problem

    Hello.

    I am doing an exercise in which I need to do the following:

    Design and implement class myArray

    myArray class must solve the array index out of bounds problem and allow the user to begin the array index starting at any integer whether it be positive or negative.

    All objects of the class are of the type int.

    The program must terminate with an error message if the index is out of bounds during execution.


    The book makes me consider the following statements:

    myArray<int> list(5);
    myArray<int> myList(2, 13);
    myArray<int> yourList(-5, 9);

    which explains

    that list has 5 components ( list[0]-list[4] )
    myList has 11 components ( myList[2] - myList[12] )
    and yourList has 14 components (yourList[-5] - yourlist[9] ).

    It then wants me to write a program to test the class.

    I am not sure if it wants me to use list, myList, or yourList stated above in the program either so I was confused about that.

    I don't want this done for me, I just need a little help here and there, usually when the ball starts rolling, I can handle it, but this time I started with an error already than I can't figure out, so maybe some prying eyes can help me out! Here's what I have, keep in mind this is just incomplete code just to get something to get it compiling.

    myArray.h
    Code:
    //Class myArray
    
    #ifndef "H_myArray"
    #define "H_myArray"
    
    using namespace std;
    
    class myArray
    {
          public:
                 myArray();
                 myArray(int x);
                 ~myArray();
                 
          private:
                  int x;
    }//End myArray Class
    
    myArray::myArray()
    {
                                       
    }//End myArray default constructor
    
    myArray::myArray(int x)
    {
                        
    }//End myArray constructor
    
    myArray::~myArray()
    {
    
    }//End myArray deconstructor
    
    #endif
    myArray.cpp
    Code:
    #include <iostream>
    #include "myArray.h"
    
    using namespace std;
    
    int main()
    {
        myArray arrayObject(5);
        
        system("pause");
        return 0;   
    }//End main

    I keep getting these errors:

    Line 2 - In file included from myArray.cpp
    Line3:9 - macro names must be identifiers

    Line 8 - in Function int main(): 'myArray' undeclared (first use in this function)
    (Each undeclared identifier is reported only once for each function it appears in.)

    Line 8 - expected ';' before "arrayObject"
    [Build Error] [myArray.o] Error 1



    Can anyone clarify what mistake I made to get these errors before I start the program?

    I think this forum is extremely helpful, so thanks to all of you in advance for helping me in any way possible!

  2. #2
    Join Date
    Oct 2006
    Location
    Sweden
    Posts
    3,632

    Re: Out of bounds array problem

    The header guards should not be string literals. Remove the "".

    A class definition should always be terminated with a ;

    Also, never put a 'using namespace' in a header. That forfeits the intention with namespace's.
    Debugging is twice as hard as writing the code in the first place.
    Therefore, if you write the code as cleverly as possible, you are, by
    definition, not smart enough to debug it.
    - Brian W. Kernighan

    To enhance your chance's of getting an answer be sure to read
    http://www.codeguru.com/forum/announ...nouncementid=6
    and http://www.codeguru.com/forum/showthread.php?t=366302 before posting

    Refresh your memory on formatting tags here
    http://www.codeguru.com/forum/misc.php?do=bbcode

    Get your free MS compiler here
    http://www.microsoft.com/visualstudio/eng/downloads

  3. #3
    Join Date
    Mar 2011
    Posts
    15

    Re: Out of bounds array problem

    Thanks for the input, it compiles beautifully now, time to get started! I will post back if I have any issues, I am not sure how I am going to attempt to complete the program but I have to do a little reading before hand and see what I can come up with and I will post my progress. Thanks so much!

  4. #4
    Join Date
    Aug 2009
    Location
    Romania->Felnac
    Posts
    48

    Re: Out of bounds array problem

    Just a little suggestion, the exercise sample arrays suggest your class should be a template, so i say you start with a template class from the beginning, so the code should look something like:
    Code:
    template<typename T>
    class myArray
    {
     public:
        myArray();
        myArray(unsigned arraySize);
        //...other c-tors - since you will need the "offset" if any
    
        //don't forget the copy c-tor and assignment operator
        //since you will have a pointer and you need to correctly copy the data
        
        ~myArray();
    
     private:
        T* data;
        unsigned size;
    };

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  


Azure Activities Information Page

Windows Mobile Development Center


Click Here to Expand Forum to Full Width

This is a CodeGuru survey question.


Featured


HTML5 Development Center