Output Sorting Error Using Pointer Notation[Beginners Question]

[basanta]

Greeting Again Codeguru World!

My code compiled well(After long Messing up with my head).
But, i still not satisfied of my output as i expected.
My code ought to sort the object of person comparing their salary. But, its not.

My code

#include <iostream>
#include <string>
using namespace std;

class person
{
    protected :
        string name;
        float salary;
    public :
        void setdata()
            {cout <<"\nEnter Name : "; cin >> name;}
        void printdata()
            {
                cout <<"\nName : " << name;
                cout <<"\nSalary : " << salary;
            }
        float getsalary()
        {cout <<"\nEnter Salary : "; cin >> salary;}
        string getname()
            {return name;}
};

int main()

{
    void bsort(person**, int);
    person* persptr[100];
    int n=0;
    char choice;
    do
    {
        persptr[n] = new person;
        persptr[n]->setdata();
        persptr[n]->getsalary();
        n++;
        cout <<"\nEnter Another(y/n)? "; cin >> choice;
    }while(choice=='y');
    cout<<"\nUnsorted List\n";
        for(int i=0;i<n;i++)
            persptr[i]->printdata();
    bsort(persptr, n);
    cout<<"\nSorted List\n";
        for(int i=0;i<n;i++)
            persptr[i]->printdata();
    cout << endl;
    return 0;
}

void bsort(person** c1, int n)
{
    void order(person**, person**);
    int i,j;
    for(i=0;i<n-1;i++)
        for(j=1;j<i;j++)
            order(c1+i,c1+j);
}

void order(person** p1, person** p2)
{
    if((*p1)->getsalary()>(*p2)->getsalary())
    {
        person* tempptr = *p1;
        *p1 = *p2;
        *p2 = tempptr;
    }
}

It doesn't sort the object of class person rather than it prints out the stored value as it is.
Thank you.

Regards
Basanta

[ZuK]

person::getsalary() doesn't return anything ( it should if I look at the declaration ) and it seems to be implemented as pure input function.
Kurt

[basanta]

person::getsalary() doesn't return anything ( it should if I look at the declaration ) and it seems to be implemented as pure input function.
Kurt

Thanks for the suggestion, I actually didn't returned float value.
I modified my class Person

Modified Code

class person
{
    protected :
        string name;
        float salary;
    public :
        void setdata()
            {cout <<"\nEnter Name : "; cin >> name;
            cout <<"\nEnter Salary : "; cin >> salary;}
        void printdata()
            {
                cout <<"\nName : " << name;
                cout <<"\nSalary : " << salary;
            }
        float getsalary()
        {return salary;}
        string getname()
            {return name;}
};

But, Still, The pointer of object of person are not sorted according to their salary. I found somehow changes in output than before but still can't fullfill the expectation.

Awaiting Suggestion..
Regards
Basanta

[VladimirF]

This implementation of bubble sort looks wrong:

for(i=0;i<n-1;i++)
    for(j=1;j<i;j++)
        order(c1+i,c1+j);