Run-time Error 52 Bad filename or number
CodeGuru Home VC++ / MFC / C++ .NET / C# Visual Basic VB Forums Developer.com
Page 1 of 2 12 LastLast
Results 1 to 15 of 17

Thread: Run-time Error 52 Bad filename or number

  1. #1
    Join Date
    Sep 2005
    Posts
    13

    Run-time Error 52 Bad filename or number

    I am trying to pass a filename from and executable to a dll and I get the error listed in the title. Any thoughts on how to correct this?

  2. #2
    Join Date
    Jun 2005
    Location
    JHB South Africa
    Posts
    3,772

    Re: Run-time Error 52 Bad filename or number

    Post the Key code that you are using then we can see to it.??

  3. #3
    Join Date
    Sep 2005
    Posts
    13

    Re: Run-time Error 52 Bad filename or number

    The actuall dll code is rather long, but the calling routine is as follows

    Private Declare Sub ParseBDF Lib _
    "C:\MyDllLibrary\BDF Parser\BDFParserDLL.dll" _
    (ByVal FName As String) ', ByRef Gctr As Integer)
    Sub Main()
    Dim FName As String

    If Command$ <> "" Then
    FName = Command$
    Else
    With Form1.CD1
    .FileName = ""
    .CancelError = True
    .DialogTitle = "Select BDF File"
    .Filter = "Bulk Data File (*.bdf)|*.bdf|All Files (*.*)|*.*"
    .Flags = cdlOFNFileMustExist Or cdlOFNExplorer Or cdlOFNLongNames
    .ShowOpen
    FName = .FileName
    End With
    End If
    MsgBox (FName)
    ParseBDF FName ', Gctr)
    Stop
    End Sub

    The dll starts as follows

    Sub ParseBDF(ByVal FName As String) ', ByRef Gctr As Integer)
    Dim FNum As Integer: FNum = FreeFile
    Dim TStr As String
    Dim tmpstr As String
    Dim tmplen1 As Integer
    Dim tmplen2 As Integer
    Dim comlen1 As Integer
    Dim comlen2 As Integer
    Dim FileType As String * 3
    Dim LineType As String

    Erase Grid
    Gctr = 0: Pctr = 0: Mctr = 0
    Close FNum
    Open FName For Input As FNum

    Line Input #FNum, TStr
    ...
    End Sub

  4. #4
    Join Date
    Jun 2004
    Location
    Kashmir, India
    Posts
    6,808

    Re: Run-time Error 52 Bad filename or number

    By going through this part of the code
    Code:
    Erase Grid
    Gctr = 0: Pctr = 0: Mctr = 0
    Close FNum
    Open FName For Input As FNum
    Line Input #FNum, TStr
    in the DLL part, How can you close anything that has not been opened yet.

    Before closing the File, you need to open it. And your function doesn't open anything prior to Close FNum statement.

    try doing this instead.
    Code:
    Erase Grid
    Gctr = 0: Pctr = 0: Mctr = 0
    Open FName For Input As FNum
    Line Input #FNum, TStr
    ...
    Close FNum

  5. #5
    Join Date
    Jun 2005
    Location
    JHB South Africa
    Posts
    3,772

    Re: Run-time Error 52 Bad filename or number

    Ok Looks like the problem is in the dll..
    Code:
    Sub ParseBDF(ByVal FName As String) ', ByRef Gctr As Integer)
    Dim FNum As Integer: FNum = FreeFile
    Dim TStr As String
    Dim tmpstr As String
    Dim tmplen1 As Integer
    Dim tmplen2 As Integer
    Dim comlen1 As Integer
    Dim comlen2 As Integer
    Dim FileType As String * 3
    Dim LineType As String
    
    Erase Grid
    Gctr = 0: Pctr = 0: Mctr = 0
    Close FNum  <----------------------- REMOVE THIS LINE
    Open FName For Input As FNum
    
    Line Input #FNum, TStr
    ...
    CLOSE FNUM   <----------------------- Place it here..
    End Sub
    Freefile will give you the next available free file number .. Closing this file number may be causing your problem..

  6. #6
    Join Date
    Jun 2005
    Location
    JHB South Africa
    Posts
    3,772

    Talking Re: Run-time Error 52 Bad filename or number

    Quote Originally Posted by vb_the_best
    Before closing the File, you need to open it. And your function doesn't open anything prior to Close FNum statement.

    try doing this instead.
    Quicker on the draw i see...

  7. #7
    Join Date
    Sep 2005
    Posts
    13

    Re: Run-time Error 52 Bad filename or number

    Actually, the close FNum statement is not the culprit. I added a message box after that line to see what FName is, and it comes up ?????????. However, just before calling the dll I have teh same message box and FName is correct. Any thoughts?

  8. #8
    Join Date
    Sep 2005
    Posts
    13

    Re: Run-time Error 52 Bad filename or number

    In the main calling code I changed the line from

    ParseBDF FName

    to

    ParseBDF StrConv(FName, vbUniCode)

    checking FName in the dll gives the correct filename for FName.

    One last question...

    Is there a way to debug or step through dlls at runtime?

  9. #9
    Join Date
    Jun 2005
    Location
    JHB South Africa
    Posts
    3,772

    Re: Run-time Error 52 Bad filename or number

    Ok instead of trying to explain here just follow this tread also in this forum

    http://www.codeguru.com/forum/showthread.php?t=357076

    I think it should help you...

  10. #10
    Join Date
    Jun 2004
    Location
    Kashmir, India
    Posts
    6,808

    Re: Run-time Error 52 Bad filename or number

    Well i wrote a small program and it seems Close statement in the above posted code will not give this error. There seems to be some other problem.

    Not sure if you can step through the DLL. As your function (in the DLL) is not a big one, you can put simple Message Boxes after each statement and then you will be able to know which statement is actually erroring out.

  11. #11
    Join Date
    Apr 2003
    Posts
    1,755

    Smile Re: Run-time Error 52 Bad filename or number

    slaphap,

    I don't know what tool you used to create the DLL you have (I saw one tool before for compiling VB apps with functions into EAT like C++) but I think you should consider a way to avoid converting from UNICODE to ANSI and vise versa. It may confuse you and might give you more error as you go on with your project.

    With the "Declare" keyword, VB converts strings from UNICODE to ANSI every time we enter the function and converts back the string (now from ANSI) to UNICODE. This would be confusing sometimes and might be hard to find where the error is. To avoid these translations, I could suggest you 2 options.

    1. The first and easiest way is to make this DLL, an activeX dll. With this, you'll make sure that they are compatible as to transferring strings from the EXE to the DLL and back.

    2. Second, you can make a type library (.TLB) for the DLL functions using the MIDL compiler. By doing this, you can tell VB that it should not translate the string and pass it as is into the function. Here's a sample for you dll function
    Code:
    [
       uuid(DD1853C1-B67B-11d6-AC3B-00001CDF360C),
       helpstring("BDFParserDLL IDL for VB")
    ]
    
    library BDFParserDLL_Lib
    {
       [dllname("BDFParserDLL.DLL")]			// the dll name
       module BDFParserDLL {
          [entry("ParseBDF")] void ParseBDF(BSTR FName);	// function name in entry()
    							// and use BSTR to tell VB it's String
       }
    }
    save it into BDFParserDLL.idl and then compile it with command
    Code:
    MIDL BDFParserDLL.idl
    Add the generated .TLB to your References and use the function without conversion concerns. This TLB will be used only for development, you don't need to distribute it with the EXE.

    When you run it, place the DLL in a location that the EXE can see it, (EG. Windows folder or on the EXE folder).

    Hope it would be of help to you.

  12. #12
    Join Date
    Sep 2005
    Posts
    13

    Re: Run-time Error 52 Bad filename or number

    Thanks for the help rxbagain. The problem is that this will be used with other source code other than VB and have been edicted to not use activeXdlls. I think I am getting a better grasp on things now. I do have a couple of questions more though..

    1. Is there a way to step through a dll for debugging purposes?

    2. Are Type declarations allowed in dlls? eg
    public type xxx
    x as integer
    y as single
    end type

    userstuff(x,x) as xxx

    Any help will be appreciated

  13. #13
    Join Date
    Jan 2009
    Posts
    1

    Re: Run-time Error 52 Bad filename or number

    I using the same code provided and can run in Excel 2007.
    But when I run it in Excel 2003 & XP, error encountered.

    compile error:
    Wrong number of argument of invalid property assignment.

    and it highlighted the on: InsertPictureInRange

    The code is as shown below:

    Sub TestInsertPictureInRange()

    InsertPictureInRange "\\semsv003\d\LF Photo\" & Range("MENU!$E$3") & ".jpg", _
    Range("CUTTING!$A77:$Z95")

    End Sub
    Sub InsertPictureInRange(PictureFileName As String, TargetCells As Range)

    ' inserts a picture and resizes it to fit the TargetCells range
    Dim p As Object, t As Double, l As Double, w As Double, h As Double

    Sheets("CUTTING").Select

    If TypeName(ActiveSheet) <> "Worksheet" Then Exit Sub
    If Dir(PictureFileName) = "" Then Exit Sub

    ' import picture
    Set p = ActiveSheet.Pictures.Insert(PictureFileName)

    ' determine positions
    With TargetCells
    t = .Top
    l = .Left
    w = .Offset(0, .Columns.Count).Left - .Left
    h = .Offset(.Rows.Count, 0).Top - .Top
    End With
    ' position picture
    With p
    .Top = t
    .Left = l
    .Width = w
    .Height = h
    End With
    Set p = Nothing

    ' ********************************************************


    End Sub


    Please advice.

    thank you.

  14. #14
    Join Date
    Jan 2006
    Location
    Chicago, IL
    Posts
    15,000

    Re: Run-time Error 52 Bad filename or number

    Please go back and reformat your code. Use CODE TAGS, and also include the connection information that you are using. You need to use 'late-binding' so that you can use any version of a product.

    Code:
    Option Explicit
    ' These are both examples of Late Binding
    
    Public Sub RunAccessMacro(strDB As String, strMacro As String)
    '================================================================
    'for late binding declare it As Object and use CreateObject() function
      Dim AccessDB As Object
      Set AccessDB = CreateObject("Access.Application")
    
        With AccessDB
            .OpenCurrentDatabase strDB
            .DoCmd.RunMacro strMacro, 1
            '.Visible = True    'you decide
            .CloseCurrentDatabase
        End With
        Set AccessDB = Nothing
    
    End Sub
    
    Public Sub ExcelMacro()
      Dim excl As Object
      Dim wrbk As Object
    
        Set excl = CreateObject("Excel.Application")
        excl.DisplayAlerts = False
        Set wrbk = excl.Workbooks.Open("myfile", , True, , "mypassword")
        excl.Run "MacroName", "arg1", "arg2"
    End Sub
    David

    CodeGuru Article: Bound Controls are Evil-VB6
    2013 Samples: MS CODE Samples

    CodeGuru Reviewer
    2006 Dell CSP
    2006, 2007 & 2008 MVP Visual Basic
    If your question has been answered satisfactorily, and it has been helpful, then, please, Rate this Post!

  15. #15
    Join Date
    Jun 2005
    Location
    JHB South Africa
    Posts
    3,772

    Re: Run-time Error 52 Bad filename or number

    Quote Originally Posted by dglienna View Post
    Please go back and reformat your code. Use CODE TAGS, and also include the connection information that you are using.
    AND ...

    this thread is over 3 years old, and is unrelated to your problem...

    Please start your own thread with appropriate title in future..

    Gremmy..
    Articles VB6 : Break the 2G limit - Animation 1, 2 VB.NET : 2005/8 : Moving Images , Animation 1 , 2 , 3 , User Controls
    WPF Articles : 3D Animation 1 , 2 , 3
    Code snips: VB6 Hex Edit, IP Chat, Copy Prot., Crop, Zoom : .NET IP Chat (V4), Adv. ContextMenus, click Hotspot, Scroll Controls
    Find me in ASP.NET., VB6., VB.NET , Writing Articles, My Genealogy, Forum
    All VS.NET: posts refer to VS.NET 2008 (Pro) unless otherwise stated.

Page 1 of 2 12 LastLast

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  


Windows Mobile Development Center


Click Here to Expand Forum to Full Width

This is a CodeGuru survey question.


Featured


HTML5 Development Center