How to encapsulate a winapi Dialog in a class?

[krs0]

I have made a simple Pane class so that I can encapsulate a winapi Dialog.
I call it as:

Here the code I have, but it displays no dialog.

Here is what I do in main:

			Pane(&hDlg, hInstance, nCmdShow);

			
			while((ret = GetMessage(&msg, 0, 0, 0)) != 0)
			{
				if(ret == -1)
					return -1;

				if(!IsDialogMessage(hDlg, &msg)) 
				{
					TranslateMessage(&msg);
					DispatchMessage(&msg);
				}
		 
			}//while

Pane.h

#pragma once

#include "stdafx.h"
#include "resource.h"

#pragma comment(linker, \
  "\"/manifestdependency:type='Win32' "\
  "name='Microsoft.Windows.Common-Controls' "\
  "version='6.0.0.0' "\
  "processorArchitecture='*' "\
  "publicKeyToken='6595b64144ccf1df' "\
  "language='*'\"")

#pragma comment(lib, "ComCtl32.lib")

class Pane
{
public:

	static HWND m_hDlg;
	MSG msg;
	HINSTANCE hInstance;
	int nCmdShow;

	Pane(HWND *hDlg, HINSTANCE hINstance, int ncmdshow);
	~Pane(void);

	static void onRestartNow();
	static void onRestartLater();
	static void onClose();

	static BOOL CALLBACK DialogProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam);
};

Pane.cpp

#include "StdAfx.h"
#include "Pane.h"

HWND Pane::m_hDlg = 0;

Pane::Pane(HWND *hDlg, HINSTANCE hINstance, int nCmdShow)
{
	InitCommonControls();
	m_hDlg = CreateDialogParam(hInstance, MAKEINTRESOURCE(IDD_DIALOG1), 0, DialogProc, 0);
	*hDlg = m_hDlg;

	HICON hIcon = LoadIcon(NULL, IDI_EXCLAMATION);
	HWND hImageCtl = GetDlgItem(*hDlg, IDC_STATIC_ICON);
	::SendMessage(hImageCtl, STM_SETIMAGE, IMAGE_ICON, (LPARAM)hIcon); 
	ShowWindow(m_hDlg, nCmdShow);
}


void Pane::onRestartNow()
{
	SendMessage(m_hDlg, WM_CLOSE, 0, 0);
}

void Pane::onRestartLater()
{
	SendMessage(m_hDlg, WM_CLOSE, 0, 0);
}

void Pane::onClose()
{
    DestroyWindow(m_hDlg);
}


INT_PTR CALLBACK Pane::DialogProc(HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam)
{
  switch(uMsg) /* more compact, each "case" through a single line, easier on the eyes */
  {
  case WM_COMMAND:
	switch(LOWORD(wParam))
    {
		case ID_RESTART_NOW: onRestartNow(); return TRUE;
		case ID_RESTART_LATER: onRestartLater(); return TRUE;
    }
    break;

  case WM_CLOSE:   onClose(); return TRUE;
  case WM_DESTROY: PostQuitMessage(0); return TRUE;
  }

  return FALSE;
}

Pane::~Pane(void)
{
}

[Paul McKenzie]

I have made a simple Pane class so that I can encapsulate a winapi Dialog.

1) Tell me what this line does:

Pane(&hDlg, hInstance, nCmdShow);

Whatever you believe it's doing, it isn't doing it, and probably the reason you're not seeing a dialog.

2) Nowhere do you check your return codes for your API calls. What if CreateDialogParam returns an error? You now have a useless object being potentially used in an application.

3) If you forget to call onClose(), your Pane destructor is not coded to clean up the resources. Look up the term "RAII". As a matter of fact, what happens if that Pane object goes out of scope without an onClose() call? You now have a resource leak.

Regards,

Paul McKenzie

[VictorN]

Did you debug your code? What does CreateDialogParam return? If the return value is NULL then call GetLastError to get extended error information.

[krs0]

1. Pane(&hDlg, hInstance, nCmdShow);
This is how I want to create and display the dialog. I put the handler in hDlg so that I can use it later in IsDialogMessage(hDlg, &msg).

2. Can you post a short example of check on one of the calls please?

3. I will add onClose() to the destructor is that enough?

[Paul McKenzie]

I have made a simple Pane class so that I can encapsulate a winapi Dialog.

To add, you really haven't encapsulated anything. You are using global (static) variables in the Pane class. All you did was rearrange where you're declaring your global variables.

If it were truly encapsulated, there would be no globals (except maybe the dialog procedure function). It takes much more thought and design to really encapsulate a dialog window than just moving your globals to a class.

Regards,

Paul McKenzie

[Paul McKenzie]

1. Pane(&hDlg, hInstance, nCmdShow);
This is how I want to create and display the dialog. I put the handler in hDlg so that I can use it later in IsDialogMessage(hDlg, &msg).

That line of code creates a temporary and that temporary is immediately destroyed. That's why I asked you what it did, and obviously you weren't aware of what it was doing.

If you want proof, put a breakpoint in the Pane destructor. When that line of code is executed, you will see the destructor magically get called. That object that was created is gone after that line is executed.

2. Can you post a short example of check on one of the calls please?

All of those functions return a value. Are you reading the documentation for those functions you're calling?

http://msdn.microsoft.com/en-us/libr...=vs.85%29.aspx

Do you see the Return value section?

Regards,

Paul McKenzie

[krs0]

2. Parts of code I have from net examples and I was trying to quickly make them work. I see now what you mean with error checks.

[mars_pat]

Hi,

You have to debug the code and need to check what is the value returned by CreateDialogParam.You can get the error info by using GetLastError. During debug if found any then mention it in the post.
Please refer http://msdn.microsoft.com/en-us/libr...(v=vs.85).aspx