CodeGuru Home VC++ / MFC / C++ .NET / C# Visual Basic VB Forums Developer.com
Page 2 of 2 FirstFirst 12
Results 16 to 17 of 17
  1. #16
    2kaud's Avatar
    2kaud is offline Super Moderator Power Poster
    Join Date
    Dec 2012
    Location
    England
    Posts
    7,824

    Re: Code does not work!!!

    Quote Originally Posted by Peter_B View Post
    You are trying to modify a string literal ("VENICE"). This will cause undefined behaviour.
    Isn't he trying to modify the contents of memory whose start address is the start address of the char array a whose contents have been set to VENICE\0? Surely changing p1-- to p2-- is all that is required in this case? This works OK with my c compiler and produces the expected output.
    All advice is offered in good faith only. All my code is tested (unless stated explicitly otherwise) with the latest version of Microsoft Visual Studio (using the supported features of the latest standard) and is offered as examples only - not as production quality. I cannot offer advice regarding any other c/c++ compiler/IDE or incompatibilities with VS. You are ultimately responsible for the effects of your programs and the integrity of the machines they run on. Anything I post, code snippets, advice, etc is licensed as Public Domain https://creativecommons.org/publicdomain/zero/1.0/ and can be used without reference or acknowledgement. Also note that I only provide advice and guidance via the forums - and not via private messages!

    C++23 Compiler: Microsoft VS2022 (17.6.5)

  2. #17
    Join Date
    Jan 2009
    Posts
    596

    Re: Code does not work!!!

    Quote Originally Posted by 2kaud View Post
    Isn't he trying to modify the contents of memory whose start address is the start address of the char array a whose contents have been set to VENICE\0? Surely changing p1-- to p2-- is all that is required in this case? This works OK with my c compiler and produces the expected output.
    Yes, I got it wrong with the string literal bit mathmari's code wasn't trying to alter the literal itself, but rather the copy which is in the char array. Thanks for correcting me. I'm so used to seeing beginners trying to modify string literals that I jumped to the wrong conclusion.

    It is indeed just the p1-- which was wrong, and should be p2--.

Page 2 of 2 FirstFirst 12

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  





Click Here to Expand Forum to Full Width

Featured