Compiler says cctor's definition does not match it's prototype

[TSLexi]

This is very strange. The compiler says my Rotor's cctor's definition doesn't match it's prototype. I can't figure out what I'm doing wrong.

Also, how can I convert my for loops into foreach loops?

Attached is the project.

Thanks!

[2kaud]

Rotor(Rotor& rhs);

Rotor::Rotor(const Rotor& rhs)

The prototype declaration is different from its definiton - the definiton is const whereas the declaration prototype isn't.

[TSLexi]

Rotor(Rotor& rhs);

Rotor::Rotor(const Rotor& rhs)

The prototype declaration is different from its definiton - the definiton is const whereas the declaration prototype isn't.

I fixed that...still get an error.

[GCDEF]

I fixed that...still get an error.

Post the current definition and prototype.

[2kaud]

Post the current definition and prototype.

...and the error it is reporting.

[TSLexi]

Strange...It compiles now.

Also, since Rotor and Enigma are tightly coupled, should I declare Rotor within Enigma's private section? A Rotor is completely useless without an Enigma.

[2kaud]

...and the error that is being reported?

[D_Drmmr]

Also, since Rotor and Enigma are tightly coupled, should I declare Rotor within Enigma's private section? A Rotor is completely useless without an Enigma.

Making Rotor a private nested class in Enigma means that only member functions and friends of Enigma can use the Rotor class. Not sure if that's what you want. If it is, you should consider whether it is possible to keep the Rotor class out of the Enigma header completely and define it in an anonymous namespace in Enigma.cpp.

If you are thinking of making Rotor a public nested class in Enigma, then your question is really a matter of taste, IMO. Using a nested class can prevent the class name from polluting the enclosing namespace. However, it can also make type names pretty long, which makes your code harder to read and it introduces a dependency on the enclosing class whenever the type is needed. I.e. you cannot forward declare a nested class without defining the enclosing class.

[TSLexi]

Rotor can only be used by Enigma, so making it private would give me the desired effect.

Refresh me on anonymous namespaces.

[2kaud]

An Unnamed namespace (eg an anonymous namespace) is a namespace defined without a name.
See http://msdn.microsoft.com/en-us/library/yct4x9k5.aspx