Winsock - sending a picture failed.

[Patry20]

FILE *PlikSave; char *bufor; char FileSize[6] = { 0 }; int BytesReceived, size, BytesReceivedTemp=0;	
BytesReceived= recv(MojSocket, FileSize, sizeof(FileSize), NULL);
size= atoi(FileSize);
bufor = (char*)malloc(sizeof(char)* size);
while(BytesReceivedTemp!=270398)
{
        BytesReceived=recv(MojSocket, bufor, SizeofFile, NULL);
        BytesReceivedTemp=BytesReceivedTemp + BytesReceived;
}
cout<<BytesReceivedTemp; //it prints 270398, correct! :)

PlikSave = fopen("D:\\C++\\Visual C\\WinSock\\Klient\\Debug\\Download2.ico", "wb");
fwrite(bufor, 1, size, PlikSave);
fclose(PlikSave);
free(bufor);

[VictorN]

...
bufor = (char*)malloc(sizeof(char)* size);
while(BytesReceivedTemp!=270398)
{
        BytesReceived=recv(MojSocket, bufor, SizeofFile, NULL);
        BytesReceivedTemp=BytesReceivedTemp + BytesReceived;
}

you are passing the same buffer bufor to every call of recv! So you overwrite the data you receied before!

[Patry20]

Yes, that's why I asked:

"So, I think that maybe is something wrong with the "bufor" variable? Maybe it is being overwritten each time the loop restarts?"

I tried strcat:

[...]
char *bufor2;
bufor2 = (char*)malloc(sizeof(char)* size);
memset(bufor2, 0, 270398);

while(BytesReceivedTemp!=270398)
{
        BytesReceived=recv(MojSocket, bufor, SizeofFile, NULL);
        strcat(bufor2,bufor);
        BytesReceivedTemp=BytesReceivedTemp + BytesReceived;
        memset(bufor, 0, 270398)  //Memseting because program was triggering a breakpoint without that.
}
fwrite(bufor2, 1, size, PlikSave);

Still cannot open the image. I suppose there is a problem with appending bufor to bufor2.

[VictorN]

Did you test a file transfer with some other file types and with smaller size?
Did you try to compare the original file with the transferred one?

[2kaud]

Why are you trying to assemble the whole buffer before you write to file? Why not first open the file and then append each chunk read to the file?

You can't use strcat as the buffer may contain a zero.

if you want to assemble the whole buffer first before writing to file, allocate memory for the whole buffer first then pass to recv the address of the part of the buffer into which you want the next chunk read. ie 0 for first pass, BytesReceived for second pass etc etc.

[Patry20]

Why not first open the file and then append each chunk read to the file?

Yes, that did the trick! Finally got it working!

Thank you guys for your time, you've been a great help.