Logical AND operator help-beginner

[zaizen]

Hey guys, On my program I am trying to have an IF statement with two conditions to equal to true that it will cout the executable code. HOWEVER, when I run it, it does NOT go through the executable code, telling me that the conditions are evaluating to false. Any help on fixing this? (specifically this section: if(color==1 && donate == Y).

#include <iostream>
#include <iomanip>
#include <cmath>
#include <cstdlib>

using namespace std;

int main()
{
const double RED = .05;
const double YELLOW = .10;
const double BLUE = .15;
const double ORANGE = .20;
const double GREEN = .25;
const int WHITE = 1;
const double extraDiscount = .05;
const double TAX = .0825;


//variable declarations
int color;
string donate;
double bookPrice;
double finalCost;
double discount;
string Y;
string N;


cout << setprecision(2) << fixed;

// Getting book and sticker information from the user
cout << "What is the marked price on your book?" << endl;
cin >> bookPrice;
cout << "Please enter the corresponding number to the sticker color on ";
cout << "your book:" << endl;
cout << "1-Red, 2-Yellow, 3-Blue, 4-Orange, 5-Green, 6-White" << endl;
cin >> color;
cout << "Would you like to donate $10 to the Special Olympics?";
cout << "(Y or N)" << endl;
cin >> donate;
cout << endl;


if(color == 1 && donate == Y )
{
discount = (RED * bookPrice) + (bookPrice * extraDiscount);
finalCost = (bookPrice - discount) + (TAX * (bookPrice - discount));

cout << "You have selected the RED sticker with a ";
cout << RED * 100 << "% discount." << endl; //converts to percentage
cout << "Your choice to donate qualifies you for an";
cout << " additional discount on this book." << endl;
cout << endl;
cout << "The marked price on your book is $" << bookPrice << endl;
cout << "You will receive a discount of $";
cout << discount << " on your book." << endl;
cout << "The discounted price of the book is ";
cout << bookPrice - discount<< endl;
cout << "Tax is " << TAX * (bookPrice - discount) << endl;
cout << "Final cost of the book is " << finalCost << endl;
}

[VictorN]

Hey guys, On my program I am trying to have an IF statement with two conditions to equal to true that it will cout the executable code. HOWEVER, when I run it, it does NOT go through the executable code, telling me that the conditions are evaluating to false. Any help on fixing this? (specifically this section: if(color==1 && donate == Y).
...

Very easy!
Either color is NOT 1, or donate is NOT equal Y.

[2kaud]

When posting code, please use code tags. As posted the code is not very readable. Go Advanced, select the formatted code and click '#'.

donate is of type string. So the test should be

if(color == 1 && donate == "Y" )

You don't need the variables Y and N.

For more info on string literals see http://www.cplusplus.com/doc/tutorial/constants/

[razzle]

if(color == 1 && donate == Y )

In the above you test whether the variables donate and Y hold the same string value.

You assign a value (a user input) to donate but Y has never been assigned a value. And since you probably want the variable Y to hold the string "Y" you can change the declaration of Y to

string Y = "Y";

Now if donate is assigned a "Y" then donate==Y will be true since Y is also "Y".

[2kaud]

In this case IMO Y should be declared const as its value isn't going to change.

const string Y = "Y";

and similarly for string N.

[2kaud]

if(color == 1 && donate == "Y" )

Are you going to have similar tests for other colours with/without donate? If you are then there are much easier ways of coding this. Have you come across arrays/structs yet?

What testing are you doing to check that the entered values for color and donate are valid? Are there values for bookPrice which can be entered but would be invalid (hint negative value)?