Hello. I need some help with my code.

[DTE102]

On this code when i run it i get the error saying that Run-Time Check Failure #2 - Stack around the variable 'heightwatermelonarray' was corrupted. It is also saying that around 'secondarray'. I have tried different things, but i am lost on how to fix this. I have tried searching this error and it tells me some things but i am not understanding them to much. Any help will be great. Thanks in advance.

#include <iostream>
using namespace std;




int main()
{
	//Variables
	int TIME;
	int	HeightofBridge;
	int count;
	int const seconds = 0;
	float HeightofWatermelon;
	float Distancefall;
	const float gravity = 9.8;



	cout << "Enter the time the watermelon falls: "; // User is asked to enter the time the watermelon fell in seconds.
	cin >> TIME;  //User enters time in seconds.

	cout << "nter the height of the bridge: "; //User is asked to enter the height of the bridge in meters.
	cin >> HeightofBridge; //User enters height of the bridge in meters.


	int secondsarray[seconds + 1];
	float heightwatermelonarray[seconds + 1];
	for (int count = 0; count < TIME; count++)
	{
		HeightofWatermelon = 0.5 * gravity * count * count;
		secondsarray[count] = count;
		heightwatermelonarray[count] = HeightofWatermelon;
	}


	cout << "Time Falling (seconds) Distance Falling (meters)\n";//Output title.
	cout << "-------------------------------------------------\n";


	Distancefall = 0.5 * gravity * TIME * TIME; //Calculation of the distnace of the fall.


	for (count = 0; count < TIME; count++)
	{
		if (Distancefall > HeightofBridge)
		{
			cout << "Warning - Bad Data: The distance fallen exceeds the " //If distnace of the fall is greater then the height of bridge then output will be a warning.
				<< "height of the bridge" << endl;
			break;
		}
		else
			cout << secondsarray[count] << "\t"
			<< heightwatermelonarray[count] << endl;
	}


	return 0;
}

[2kaud]

int const seconds = 0;
...
int secondsarray[seconds + 1];
...
for (int count = 0; count < TIME; count++)
..
    secondsarray[count] = count;

seconds is a constant and is set to 0. Hence the array secondsarray has a size of 1 element accessed as secondsarray[0]. Within the for loop, count varies from 0 to 1 less than TIME - hence when count is greater than 0 the arrays are being accessed outside of their size and hence the error. The size of the arrays needs to be set at compile time to be the largest required. Or better, use a container such as a vector to store the data which can be added to at run-time without knowing in advance its maximum size. See http://www.cplusplus.com/reference/vector/vector/

[DTE102]

Okay thank you for the response. So let me ask this when i change the size of my array am i taking the +1 out that I have or do i need to change the count?

[2kaud]

Yes, you take the + 1 out. The valid entered value of TIME should be no greater than the value of seconds. So initialise seconds to the required max value and after TIME has been entered check its value is valid.

[DTE102]

okay so i took that out and my int const seconds i changed to 1. I am still getting the error. I know this is probably something simple but i am very new at this and i just want to make sure i am doing things correctly.

[2kaud]

If you have changed seconds to 1, then the max value for TIME is 1. What value for TIME are you entering?

[2kaud]

Consider

...
int const seconds = 100;
const float gravity = 9.8;

int main()
{
	//Variables
	int TIME;
	int	HeightofBridge;
	int count;
	float HeightofWatermelon;
	float Distancefall;


	cout << "Enter the time the watermelon falls: "; // User is asked to enter the time the watermelon fell in seconds.
	cin >> TIME;  //User enters time in seconds.

	if (TIME < 1 || TIME > seconds) {
		cout << "Invalid value for TIME. Must be greater than zero and no greater than " << seconds << endl;
		return 1;
	}

	cout << "Enter the height of the bridge: "; //User is asked to enter the height of the bridge in meters.
	cin >> HeightofBridge; //User enters height of the bridge in meters.


	int secondsarray[seconds];
	float heightwatermelonarray[seconds];
...

[DTE102]

Thank you for your help. I finally got it to work. All i did was change int const second to 100 instead of just 1.

[2kaud]

Yes, but you should include the range check for TIME. If you enter a value higher than 100 for TIME you're going to have similar problems.