[RESOLVED] MFC ProgressBar makes Application Slow

[eclessiastes]

Hello
I have a problem with my progress bar:

                        std::string line;
			std::ifstream infile(ExtractFromFile, std::ios::binary);
			while (std::getline(infile, line))
			{
				MainDialog->StockList.push_back(line.c_str());
				TProgressBar.SetStep(1);
				TProgressBar.StepIt();
			}

My list has about 5 MB. If i use TProgressBar stepit() then it takes about 20 seconds, without it it takes about 1 second. The difference is huge.
Is there any way to make it faster ?
Thank you!

[Arjay]

Change the step size and only set the step on every 10 lines. There's no need to be that granular.

[2kaud]

Why are you setting the step size every time through the loop?

[eclessiastes]

 
		        int CountNr = 0;
                        std::string line;
		        std::ifstream infile(ExtractFromFile, std::ios::binary);
			while (std::getline(infile, line))
			{
		                CountNr++;
				MainDialog->StockList.push_back(line.c_str());
		                if (CountNr==10) {
				TProgressBar.SetStep(10);
				TProgressBar.StepIt(); }
			}

Now its 10 times faster.
Thank you guys!

[2kaud]

Why is SetStep() within the loop?

When CountNr equals 10, shouldn't it be reset to 0?

[Igor Vartanov]

		        int CountNr = 0;
		        int step = 100;
			TProgressBar.SetStep(step);
                        std::string line;
		        std::ifstream infile(ExtractFromFile, std::ios::binary);
			while (std::getline(infile, line))
			{
		                CountNr++;
				MainDialog->StockList.push_back(line.c_str());
		                if (0 == CountNr % step)
					TProgressBar.StepIt();
			}