For loops and if statement to accept word to listbox, needs 2 reoccurring letters

[neymark]

int i = 0;
//  int j = i + 1;
int charCount = 0;

for(i=0; i<word.Length;i++)
{
    for ( int j= 1; i < word.Length; j++)
    {
        if(word.Substring(i)==word.Substring(j))
        {
            charCount++;
        }
               
    }
}

if (charCount!=0)
    MessageBox.Show("Word Accepted");
else
    MessageBox.Show("Word Accepted");

[2kaud]

When posting code, please use code tags. Go Advanced, select the formatted code and click '#'.

and your c# question is? Do you really want it to display 'Word Accepted' under any circumstance? - both parts of the if statement display the same message!

[neymark]

Sorry, just noticed that if its not equal to 0, it should not accept word into listbox

[neymark]

Sorry, just noticed that if its not equal to 0, it should not accept word into listbox

Any idea of how i can get it to work?

[2kaud]

you haven't said what is the problem. Have you debugged the program using the debugger - tracing through the code to see where it deviates from what expected?

[neymark]

you haven't said what is the problem. Have you debugged the program using the debugger - tracing through the code to see where it deviates from what expected?

The problem is that It always displays 'word accepted' even if i enter a word with no reocurring letters?

[2kaud]

for ( int j= 1; i < word.Length; j++)

Don't you mean j < word.Length?

What happens when i is 1 and j is 1? The test is always equals! Shouldn't the test exclude the case j == i?

if(j != i && word.Substring(i)==word.Substring(j))

[neymark]

for ( int j= 1; i < word.Length; j++)

Don't you mean j < word.Length?

What happens when i is 1 and j is 1? The test is always equals! Shouldn't the test exclude the case j == i?

if(j != i && word.Substring(i)==word.Substring(j))

So i should take out the j==1 ?and replace it with?

[2kaud]

So i should take out the j==1 ?and replace it with?

Change the if test as per my post #7

[neymark]

Change the if test as per my post #7

I tried that, its still saying word accepted if i only have no reoccuring letters.
could it possible be the if statement below the for loops?

[Arjay]

The problem is that It always displays 'word accepted' even if i enter a word with no reocurring letters?

It always says the 'word accepted' because that's what you programmed it to do. You've written 'Word Accepted' twice.

if (charCount!=0)
    MessageBox.Show("Word Accepted");   // 1st time
else
    MessageBox.Show("Word Accepted");  // 2nd time - oops

[neymark]

i have it changed and it still is doing it.

[2kaud]

Can't give you c# code, but for c++ the code below works OK.

#include <iostream>
#include <string>
using namespace std;

int recur(const string& word)
{
	int i = 0;
	int charCount = 0;

	for (i = 0; i < word.length(); i++)
	{
		for (int j = 1; j < word.length(); j++)
		{
			if (j != i && word[i] == word[j])
			{
				charCount++;
			}

		}
	}

	if (charCount)
		cout << word << " accepted" << endl;
	else
		cout << word << " not accepted" << endl;

	return charCount;
}

int main()
{
	recur("qwerty");
	recur("qwetqy");
}

[2kaud]

Also note that using two loops has a complexity of O(n*n). By using an array and just one loop this complexity can be reduced to just O(n). Consider (again c++ - sorry)

#include <iostream>
#include <string>
using namespace std;

int recur(const string& word)
{
	int cnt[256] = { 0 };
	int charCount = 0;

	for (int i = 0; i < word.length(); i++)
		charCount += cnt[word[i]]++;

	if (charCount)
		cout << word << " accepted" << endl;
	else
		cout << word << " not accepted" << endl;

	return charCount;
}

int main()
{
	recur("qwerty");
	recur("qwetqy");
}

[neymark]

Cheers i think ive got it working. Would you have any idea how i would go about a method accepting the word aslong as it it must start with vowel?