CodeGuru Home VC++ / MFC / C++ .NET / C# Visual Basic VB Forums Developer.com
Results 1 to 3 of 3

Thread: comparing characters in a string

  1. #1
    Join Date
    Aug 2018

    comparing characters in a string

    Hello coders

    The code below is supposed to take first 2 characters from the main string and put it into string twochars the next 2 characters go into another string secondtwochars. If the charcters of the temp strings are equal it will increment a counter and get the next two string of 2 characters each until the main string is over but it is giving bogus data
    eg: string : efef3030 should be ef023002 but its not please help

    string comparision(string hextext) {
        //string hextext = "";
        int counter;
        int length = hextext.size();
        std::string twochars = "";
        std::string secondtwochars = "";
        trace() << "Input : " << hextext ; 
        string runlengthengthcoding = "";
        /*for(int w=0;w<52;w++){
            if(temphexholder[0] == databytes[w]){
            if(temphexholder[0] != databytes[w]){
                runlengthengthcoding += databytes[w] + counter; 
                counter = 0;
                temphexholder[0] = databytes[w];
        } */
        for(int i=0 ; i< length; i+=4)
            twochars = hextext.substr(i, 2) ;
            for(int k=2 ; k< length; k+=4)
            secondtwochars = hextext.substr(k, 2) ;
            if(twochars == secondtwochars){
            if(twochars != secondtwochars){
                string counters = to_string(counter);
                runlengthengthcoding += twochars + counters;    
                counter = 0;
        return runlengthengthcoding; 
    int main (){
    string t = "30304040";
    cout << comparison(t); 

  2. #2
    VictorN's Avatar
    VictorN is offline Super Moderator Power Poster
    Join Date
    Jan 2003
    Hanover Germany

    Re: comparing characters in a string

    What is temphexholder?
    Victor Nijegorodov

  3. #3
    2kaud's Avatar
    2kaud is offline Super Moderator Power Poster
    Join Date
    Dec 2012

    Re: comparing characters in a string

    What debugging of the code has been done? Has the debugger been used to trace through the code line by line and the contents of the variables watched? If not, now's the time to learn how to use the debugger. if yes, where did the code deviate from that expected from the program design?
    All advice is offered in good faith only. All my code is tested (unless stated explicitly otherwise) with the latest version of Microsoft Visual Studio (using the supported features of the latest standard) and is offered as examples only - not as production quality. I cannot offer advice regarding any other c/c++ compiler/IDE or incompatibilities with VS. You are ultimately responsible for the effects of your programs and the integrity of the machines they run on. Anything I post, code snippets, advice, etc is licensed as Public Domain https://creativecommons.org/publicdomain/zero/1.0/ and can be used without reference or acknowledgement. Also note that I only provide advice and guidance via the forums - and not via private messages!

    C++17 Compiler: Microsoft VS2017 (15.7.6)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Windows Mobile Development Center

Click Here to Expand Forum to Full Width

On-Demand Webinars (sponsored)