[RESOLVED] C++ While loop, Looking for a bit of help.

[iiMortaaaL]

Hi guys,

So I've been give the task of writing a program so a user can input a module code and multiple coursework marks. When the user is finished entering the details they will type in "-1" and it will end the loop and display the average.

The problem i have is that when i go to calculate the average it keeps counting the "-1" as a course mark. I was wondering how to fix this as i have no idea.

Here is the code below.

#include <iostream>
        //including packages
using namespace std;

int main()             //declaring main
{
	    int modulecode = 0;
		float average = 0;
		int counter = 0;                                  //declaring variables
		float input = 0;//store user input
		float total = 0; //store total

		cout << "enter module code" << endl;
		cin >> modulecode;


		while (input !=-1)
		{
			cout << "Enter a coursework grade or -1 to quit : ";
			cin >> input;
			total = total + input;
			counter = counter + 1;
		}//end while

		average = total / counter;
		cout << "total is : " << total;
		cout << "the average is : " << average;
		
	return 0;
}

thanks in advance.

[iiMortaaaL]

Problem solved.

[2kaud]

[When posting code, please use code tags so that the code is readable. Go Advanced, select the formatted code and click '#']

cin >> input;
total = total + input;

You are obtaining the input value and adding it to the total without first checking that it's not -1. So -1 will be included in the average. You need to only add to total and increment the counter if the input is not -1.

[2kaud]

Problem solved.

Great!