GCDEF is right suit should be just a string not an array Also you have some other errors that have not been mentioned so far in your code:
in getcards() your for loop condition is wrong should be just x < i because you index from 0 upwards Another thing is you shouldnt call srand in pickcard() because it forces the rand function to generate the same value, just call it once before the for loop in your deal(Hand&,Hand&) function
Hope this helps a bit