[RESOLVED] Help with my app

[Pale]

I was working on an app that downloads and installs addons for an online game.

I absolutely can not figure out what is wrong with it, i try debuging and it doesn't even step into the next thread.

If anyone is willing to look over it i will attach the source.

The amount of code in it is far too much to post.

Advice and suggestions welcome.

Thank you.

[toraj58]

please post the part of your code that you think it is faulty and also error and warnings you recieved.

[Arjay]

You need to start the thread.

       private void btnInstall_Click( object sender, EventArgs e )
        {
            if( Locations.Addons == null )
            {
                GMAI.WriteLine( "You do not have Garrys Mod installed!" );
            }
            else
            {
                EnableItems( false );
                listFailed.Items.Clear( );
                MainThread = new Thread( new ThreadStart( ExecutionPoint ) );
                MainThread.Start( );
            }
        }

I'd recommend following the C# naming conventions as well.

1) Namely private fields are camelCase (and preferably are prefixed with an underscore).
2) Public static fields and Properties are PascalCase.

Using this naming, MainThread (a private field) would become _mainThread and GMAI.download (a public static field) would become GMAI.Download.

[Arjay]

Lastly, the Locations code is very fragile.

For example, this class won't initialize if \\Gmod Addons\\ isn't a sub-folder of 'My Documents'.

I know you expect folks to have Steam or Garry's mods installed, but consider failing more gracefully if they don't.

The following doesn't allow for gracefull failing (if the Gmod... folder isn't present):

public static readonly string Save = Environment.GetFolderPath( Environment.SpecialFolder.MyDocuments ) + "\\Gmod Addons\\";

One strategy is to check for these folders and to display a message box if a needed folder isn't present.

[Pale]

Lastly, the Locations code is very fragile.

For example, this class won't initialize if \\Gmod Addons\\ isn't a sub-folder of 'My Documents'.

I know you expect folks to have Steam or Garry's mods installed, but consider failing more gracefully if they don't.

The following doesn't allow for gracefull failing (if the Gmod... folder isn't present):

public static readonly string Save = Environment.GetFolderPath( Environment.SpecialFolder.MyDocuments ) + "\\Gmod Addons\\";

One strategy is to check for these folders and to display a message box if a needed folder isn't present.

Thanks again Arjay, it was late and now i feel REALLY stupid for not adding MainThread.Start();

And thanks for the info about the fragile class code. Ill fix them.