Whats wrong with this code? Msgbox

private Sub Drive1_Change()
on error GoTo nodisk
Dir1.Path = Drive1.Drive
Text3.Text = Drive1.Drive

nodisk: MsgBox "There is no disk in that Drive", vbRetryCancel, "a Phrozen error"

If nodisk = vbRetry then
Dir1.Path = Drive1.Drive
Text3.Text = Drive1.Drive
else
Drive1.Drive = "c:\"
Dir1.Path = "c:\"
Text3.Text = "c:\"
End If
End Sub




http://forums.codeguru.com/Thankz, Drew
[email protected]?SUBJECT=I Love Your Stuff

Either you have an error or not you will get the message "There is no disk in that Drive".

Iouri Boutchkine
[email protected]

now VB is returning Errors all over the place in my project. whats wrong?

http://forums.codeguru.com/Thankz, Drew
[email protected]?SUBJECT=I Love Your Stuff

Put in Exit Sub after this line


Text3.Text = Drive1.Drive



David Paulson

Here is your routine revised somewhat.
You need to do an Option Explicit to ensure all variables are defined. YOu need to Exit the Sub if everything goes well or you will fall into the error routine and execute it. The MsgBox needs to be a function so it can return the users response so I altered it as you can see

option Explicit ' add this line
Dim strTemp as string
private Sub Drive1_Change()
Dim noDisk as Integer ' add this line
on error GoTo noDisk
Dir1.Path = Drive1.Drive
Text3.Text = Drive1.Drive
Exit Sub ' Add this line
noDisk:
' next line revised
noDisk = MsgBox("There is no disk in that Drive", vbRetryCancel, "a Phrozen error")
If noDisk = vbRetry then
Dir1.Path = Drive1.Drive
Text3.Text = Drive1.Drive
else
Drive1.Drive = "c:\"
Dir1.Path = "c:\"
Text3.Text = "c:\"
End If
End Sub




John G