Printable View
hi all,
my following program is not working, can anyone please tell me what's wrong with that?
Code:class Example
{
private:
char *name;
public:
Example()
{
name = new char[20];
}
~Example()
{
delete[] name;
}
Example(const Example &b)
{
name = new char[20];
strcpy(name, b.name);
}
void setName(char* n)
{
name=n;
}
char* getName()
{
return name;
}
};
int main()
{
Example b;
char* n=NULL;
cin>>n;
b.setName(n);
cout<<b.getName();
return 0;
}
How is it not working? Does it not compile? Does it crash? Does it not produce the output you expected?
Also, did you step through your program using the debugger?
What did you expect to happen here? Since you use C++ why not use a std::string instead?Quote:
Originally Posted by Aashi
it complies, takes input and then program crashes.Quote:
Originally Posted by D_Drmmr
I know, but i want to use this for learning.Quote:
Originally Posted by S_M_A
please tell how can i make my program working? it crashes after taking input.
Where is cin supposed to store the input when you make n a NULL-pointer?
Part of learning how to program is to know how to debug your own code. Just writing code and then dumping it here waiting for us to debug it is not the way you learn how to write a program. You must make the effort to debug your own code. You wrote it, you must be able to debug it.Quote:
Originally Posted by Aashi
Can you at the very least identify which line causes the crash? Once you figure out which line it crashes on, look at that line and learn what could have happened. Use the debugger that comes with your compiler to step through the program.Quote:
please tell how can i make my program working? it crashes after taking input.
Regards,
Paul McKenzie
Modifying these two lines....
like so...Code:char* n=NULL;
cin>>n;
... should get the program to run for you.Code:char n[256] = { '\0' };//Declares n to be a character array of length 256 and initializes all elements to terminating NULL character
cin.getline(n, 255);//Reads user input, ensuring that room remains for the terminating null character
The problem here is that you've declared n as a pointer to an array of characters but you never initialize it. If you do not declare the size of a character array at compile time, then you must either point it to some character array or dynamically allocate a new character array at run time before you can use it in any meaningful way. See this link for an excellent tutorial on pointers (the next chapter will talk about character arrays specifically), and the one after that, about dynamic memory allocation). You should come away from it understanding why what you're trying to do here doesn't work.
alright then, can you please tell me about how can i get input from user in a main using setter function?Quote:
Originally Posted by Paul McKenzie
i'm not asking for code, here's my code with constructor and destructor where i'm dynamic allocating a char type indentifier. would be appreciated if you help me.
Code:#include <iostream>
using namespace std;
class Example
{
private:
char* str;
int len;
static int num_strings;
public:
Example(const char* s);
Example();
~Example();
void setName(char* n);
char* getName();
};
int Example::num_strings=0;
Example::Example(const char* s)
{
len=strlen(s);
str=new char[len+1];
strcpy(str,s);
num_strings++;
}
Example::Example()
{
len=4;
str=new char[4];
strcpy(str,"C++");
num_strings++;
}
Example::~Example()
{
num_strings--;
delete[] str;
}
void Example::setName(char* n)
{
strcpy(str,n);
}
char* Example::getName()
{
return str;
}
int main()
{
Example e("me");
e.setName("Aashi");
cout<<e.getName();
return 0;
}
here's updated code, it's working but is this the right way?
please respond..
Code:#include <iostream>
using namespace std;
class Example
{
private:
char* str;
int len;
static int num_strings;
public:
Example(const char* s);
Example();
~Example();
void setName();
char* getName();
};
int Example::num_strings=0;
Example::Example(const char* s)
{
len=strlen(s);
str=new char[len+1];
strcpy(str,s);
num_strings++;
}
Example::Example()
{
len=4;
str=new char[4];
strcpy(str,"C++");
num_strings++;
}
Example::~Example()
{
num_strings--;
delete[] str;
}
void Example::setName()
{
str=new char[2000];
cin.getline(str,2000);
}
char* Example::getName()
{
return str;
}
int main()
{
Example e("me");
e.setName();
cout<<e.getName();
return 0;
}
No it does not work.Quote:
Originally Posted by Aashi
One question -- why are you using char pointers and 'C' functions to do something that can be easily done using std::string?
First, that code will fail miserably if I just did this:
The reason why it fails is that in the destructor, the same pointer is deleted twice, causing undefined behaviour. You also now have a memory leak.Code:int main()
{
Example e("me");
Example e2("you");
e = e2;
}
Here is another failure:
Now you have a memory leak. The reason is that you did not deallocate the original memory used by the str pointer.Code:int main()
{
Example e("me");
e.setName();
}
Bottom line is that if you quit using char pointers and instead used std::string, all of these issues disappear.
There is no memory allocation being done, no memory leaks, no undefined behaviour. There is also no need to guess how many characters you need, as the string is dynamically resized.Code:#include <iostream>
#include <string>
using namespace std;
class Example
{
private:
std::string str;
public:
Example(const std::string& s);
Example();
void setName();
std::string getName();
};
Example::Example(const std::string& s) : str(s)
{}
Example::Example() : str("C++")
{}
void Example::setName()
{
getline(cin, str);
}
std::string Example::getName()
{
return str;
}
int main()
{
Example e("me");
e.setName();
cout<<e.getName();
return 0;
}
If you insist on using char pointers, then you need to learn how to write copy constructor, assignment operator, and know exactly how to manage dynamically allocated memory correctly. But why do that when the code above does everything, easier and safer.
Regards,
Paul McKenzie
Why not learn from tutorials as well? Also read faqs. They can provide common pitfalls and how to avoid them. Googling your question first is even better if you can generalize it.Quote:
Originally Posted by Aashi
What happened to your previous str pointer?Code:void Example::setName()
{
str=new char[2000];
cin.getline(str,2000);
}
Is len updated to the new string length?
How can I set a name without using the console?
What if I have a const Example me and want to call me.getName()?Code:char* Example::getName()
{
return str;
}
thanks,