Phone Number Program

Hello everyone, I am new to this forum and am looking for some assistance, any help would be greatly appreciated! I am stuck on this assignment for my programming fundamentals 1 class and am desperate at this point as I have been stuck for hours on end. Thank you.

Here is the prompt:
Many websites ask for phone numbers. The problem is that there are so many
different ways to represent a phone number. Examples include 817-555-1234,
817 555 1234 (c), and (817) 555-1234 x23. Write a C++ program which inputs
a string containing a phone number in any format and outputs it in the standard
format. For this assignment, the standard format is (817)555-1234.
Your c++ program should:
1. Input a string including the number
2. Copy only the digits from the input string into another string
3. Issue an error message if the input string does not contain exactly 10
digits
4. Output the phone number in standard format

Code:

---

#include "stdafx.h"
#include <iostream>
#include <iomanip>
#include <string>
#include <cctype>
using namespace std;

const int NUM_LENGTH = 10;

string ReadAndValidateUserNumber(string userNumber);

int main()
{
        string userNumber;

        ReadAndValidateUserNumber(userNumber);

        system("PAUSE");
        return 0;
}

string ReadAndValidateUserNumber(string userNumber)
{
        bool check = false;

        while (!check)
        {
                check = true;

                cout << "Please enter a Number: ";
                cin >> userNumber;

                if (userNumber.length() != NUM_LENGTH)
                        cout << "The phone number may contain 10 digits only. \n";
               
                else
                {
                        userNumber.insert(0, "(");
                        userNumber.insert(4, ")");
                        userNumber.insert(8, "-");

                        for (int i = 0; i < userNumber.length(); i++)
                        {
                                if (isdigit(userNumber[i]))
                                {
                                        userNumber = NUM_LENGTH;
                                }
                        }
                }

                if (!check)
                {
                        cout << "Invalid Entry! Please try again." << endl;
                }
        }

        return userNumber;
}

---

[When posting code, please use code tags. Go Advanced, select the formatted code and click '#']

Quote:

---

I am stuck on this assignment for my programming fundamentals

---

You don't actually say what is the problem?

Code:

---

cout << "Please enter a Number: ";
cin >> userNumber;

if (userNumber.length() != NUM_LENGTH)
        cout << "The phone number may contain 10 digits only. \n";

---

You are entering the phone number as a string and then checking if the length of the entered string is the required 10. However, the assignment is to check that the entered string contains 10 digits, not that its total length is 10.

Also note that string stream extraction does not extract as one string characters containing a space. The extraction will only obtain the characters prior to the space. To obtain the whole entered string use .getline(). See http://www.cplusplus.com/reference/s...tring/getline/

Code:

---

userNumber.insert(0, "(");
userNumber.insert(4, ")");
userNumber.insert(8, "-");

for (int i = 0; i < userNumber.length(); i++)
{
        if (isdigit(userNumber[i]))
        {
                userNumber = NUM_LENGTH;
        }
}

---

userNumber is of type string and NUM_LENGTH is of type int. You can't assign an type int to a type string. Also, before the loop you are inserting characters into the string and then checking for non-digits in the string!

I would suggest that you first work out on paper how to determine if a given string is a valid phone number, then produce a program design and then code the program from the design.

Quick scanning...

your Boolean check flag is not taken care of. Your while loop is so the second check flag is never triggered...

maybe I'm not good with strings, but user number input seems to exceed 10 438-848-2415.. unless condesned like 5142528448, most cases

also

userNumber = NUM_LENGTH

seems a looping condition rather than a string building instructions