How to print "1" ?

Usually string builder is the fastest way to buid string.... but IMHO not in this case. Especialy when darwen uses that loop and conditional assigment ;) ...

Quote:

---

but if using its default constructor will set its start buffer size at zero

---

No - its starts at 16.

Quote:

---

The above case is the most efficient

---

Im not so sure....
disregarding the initial decoration of code :D :D , there are 3 temporary strings, one temporary object and 5 copy instructions.
I'm not saying that string builder is slower, but string builder is designed for fast building of large strings.With smaller strings it can be actually slower than concatenting strings with "+".

darwen: Last solution ... looks like it can produce valid output - so for the moment U are a winner! :D

Code:

---

int nEstimateOfIntSize = (i <= 0) ? 1 : 0;

int iCount = i;

while (iCount != 0)
{
    nEstimateOfIntSize += 1;
    iCount /= 10;
}

---

Too much code here. This is the same.

Code:

---

int nEstimateOfIntSize = 1+(int)System.Math.Log10(i);

---

Quote:

---

Too much code here. This is the same.

---

And I have shorter one:

Code:

---

int nEstimateOfIntSize =10

---

Why? - because more precision is not needed.StringBuilder operations will not gain any performance boost if initial storage size will be better fited. (in extreeme case it will allocate space for 9 chars too much)... so better use max length of int string (=10).

darwen:

Code:

---

label1.Text = "u have chosen \"\"".Insert(15,i.ToString());

---

or

Code:

---

label1.Text = "u have chosen \"#\"".Replace("#",i.ToString());

---

:D

Best regards,
Krzemo.

Wouldn't it be just as easy and efficient to do my original suggestion ?

Code:

---

string sMessage = string.Format("u have chosen \"{0}\"", i);

---

Yeah I know that loop was horrible but I was in a bit of a rush and not thinking.

Darwen.

Quote:

---

Originally Posted by Krzemo

Why? - because more precision is not needed.StringBuilder operations will not gain any performance boost if initial storage size will be better fited. (in extreeme case it will allocate space for 9 chars too much)... so better use max length of int string (=10).

---

Didn't we all forgot something here? The possible '-' sign...
-1,234,567,890
Well, Darwen didn't.

Code:

---

int nEstimateOfIntSize = (i <= 0) ? 1 : 0;

---

So, to adjust my code:

Code:

---

int nEstimateOfIntSize = (i<0?2:1)+(int)System.Math.Log10(i>0?i:-i);

---

and you have to do:

Code:

---

int nEstimateOfIntSize =11.

---

Quote:

---

and you have to do:
Code:
int nEstimateOfIntSize =11.

---

In general case - Yes:)

Quote:

---

Yeah I know that loop was horrible but I was in a bit of a rush and not thinking.

---

He, he - too much cafee!

Quote:

---

Wouldn't it be just as easy and efficient to do my original suggestion ?

---

efficient.... it depends if string parsing is made at compile or at run time.
I think it is worth to check it... but maybe later.

Best regards,
Krzemo.

Quote:

---

In general case - Yes

---

You have to take into account all case or you'll find yourself wondering why isn't the app working. ;)

Quote:

---

You have to take into account all case or you'll find yourself wondering why isn't the app working. ;)

---

Sometimes, having negative value means that your application is already not working ;) .
But as I said before, it is irrelevant for stringbuilder (as far as performance is concern) if U use initial storage as 10,11,20 etc (of course if that value is small and U have enough memory available:) ). And if initial storage is too small, string buider alocates new: 2* size of storage size. So it will require low number of reallocations (geometrical speed). So really nothing happens when initial size is too small on the start ;).

Best regards,
Krzemo.

Quote:

---

Originally Posted by Krzemo

But as I said before, it is irrelevant for stringbuilder (as far as performance is concern) if U use initial storage as 10,11,20 etc (of course if that value is small and U have enough memory available:) ). And if initial storage is too small, string buider alocates new: 2* size of storage size. So it will require low number of reallocations (geometrical speed). So really nothing happens when initial size is too small on the start ;).

---

I understand that. I was just saying that in general, all cases should be taken into account.

hacky, but to clean it up wouldn't be in teh right spirit...the variable i is assumed to be any positive 32bit int.

i think this is pretty efficient, given that it avoids things such as hidden boxing when using object methods, and (as i understand it)
it pretty much does what stringbuilder does.

btw, how can one past code from VS and not have huge indentations such as these?

Code:

---

using System;

namespace CGF
{
       
        class LabelText
        {
                public static void Main( )
                {
                        char[] labelText =  {
                                                          'u', ' ', 'h',
                                                          'a', 'v', 'e',
                                                          ' ', 'c', 'h',
                                                          'o', 's', 'e',
                                                          'n', ' ', /*quote*/(char)0x0022,
                                                                        /* spaces for 10 digits, max
                                                                          * possible for System.Int32,
                                                                        * also terminators for a string */
                                                                (char)0x0000, (char)0x0000, (char)0x0000,
                                                                (char)0x0000, (char)0x0000, (char)0x0000,
                                                                (char)0x0000, (char)0x0000, (char)0x0000,
                                                                (char)0x0000                                                                };       
                        // the is where we will start changing the array values
                        // based on teh user input
                        int QUOTE_POSITION = 15;

                        // assume i > 0
                        int i = 1;

                        string str;

                        unsafe
                        {
                                fixed(char* carrPtr = labelText)
                                {
                                        char* cp = carrPtr;

                                        cp += QUOTE_POSITION;

                                        int j = i;
                                        int n = (int)Math.Log10(j);
                                       
                                        while(n>=0)
                                        {
                                                int k = (int)Math.Pow(10,n);

                                                // offset the value of j/k by 48 to get the
                                                // unicode value for the numeric character
                                                *cp = (char)(48 + (j / k));
                                               
                                                // remove the leading digit from j so we can
                                                // get the next digit on the next pass
                                                j = j - ((*(cp++)-48) * k);

                                                n--;
                                        }
                                        *cp = (char)0x0022;

                                        str = new string(carrPtr);
                                }
                        }
                       
                        Console.WriteLine(str);
                        Console.Read();
                }
       
               
        }
}

---

Wow !

U have definetely too much spare time :D .

Quote:

---

it pretty much does what stringbuilder does.

---

No, but I think (in that particular case) your code can be the most eficient:thumb: solution (If its working ...I didn't compile it :rolleyes: ).

Best regards,
Krzemo.

Oh my God! Somebody stop Issa until is too late! :D I'm too tired to try to undertand the code but I'll send you a bottle of champagne. My advice, get a life, get a job, stop writing Label classes. :D ;)
:wave:

Quote:

---

Originally Posted by cilu

My advice, get a life, get a job, stop writing Label classes. :D ;)
:wave:

---

pff Label classes are my favourite! ;)

Quote:

---

Originally Posted by Issa

btw, how can one past code from VS and not have huge indentations such as these?

---

If you click "Tools" -> "Options" -> "Text Editor" -> "C#" -> "Tabs" and then select the "Insert Spaces" radio button, that will probably stop it. But then you get other problems when you are actually doing your coding because it stores spaces not tabs. and when you edit someones code who likes 4 spaces per tab and you like 3, it's a pain in the ***.

So do what I do - live with it! :D

and for the microseconds difference it's going to make doing it any other way, my votes on Darwens first post.

Zeb:

Quote:

---

my votes on Darwens first post.

---

It is not a poll:D .
It is a competition: "Last One who provide valid solutions WINS! :D :D :D "
And last One is Issa solution - so he is the winner now!:cool:

Quote:

---

and for the microseconds difference ...

---

Did U measure it up or it is your internal believe?:p

Best regards,
Krzemo.
:wave: