String conversion

Quote:

---

Originally Posted by PredicateNormative

Hi Hermit, my mistake, the interface should have been:

Code:

---

template <typename T> std::string StringToLower(const T& str);

---

I've conceded on the correctness of modifying the string through its iterators, I just didn't want the input string modified because it would impact other code. Thanks for the suggestion. :)

---

What if I call the function like this?

Code:

---

double x(1.5);
std::string lowerCase = StringToLower(x);

---

What happens then? In other words, why do you think that the input should be a template parameter and not a std::string? This interface that you posted seems nonsensical to me and would allow someone to call the function with any type. Is that really what you intend?

Quote:

---

Originally Posted by kempofighter

What if I call the function like this?

Code:

---

double x(1.5);
std::string lowerCase = StringToLower(x);

---

What happens then? In other words, why do you think that the input should be a template parameter and not a std::string? This interface that you posted seems nonsensical to me and would allow someone to call the function with any type. Is that really what you intend?

---

That will not compile since a double cannot be assigned to a string, so there is no problem. ;) The point of the template is to allow the function to be called with an input of type std::string, char* or char[].

But inside the function you are converting str to a string, so you might as well make the parameter a non-referenced string because it will do the same thing.

Code:

---

std::string StringToLower(std::string tmp)
{
  std::transform(tmp.begin(), tmp.end(), tmp.begin(), tolower);
  return tmp;
}

---

That's true enough. :)