Problem in vector.

I have a class pagedetails , i am storing objects of pagedetails in a vector.

I want to access the elements of the vector using an iterator.

Code:

---

std::vector<Pagedetails*> subcontentlist;

subcontentlist.push_back(objptr->subcontent);

vector<Pagedetails*>::iterator p = subcontentlist.begin();

---

Quote:

---

Here objptr->subcontent returns a Pagedetails object.

---

p should contain address of the Pagedetails object.

This does not happen. Can anyone help me?
rgds
swetha

In the code snippet you provided p contains the address of a pointer to Pagedetails. You have to dereference the iterator to obtain a pointer to a Pagedetails object.

Code:

---

std::vector<Pagedetails *> subcontentlist;

subcontentlist.push_back(objptr->subcontent);

vector<Pagedetails*>::iterator p = subcontentlist.begin();

Pagedetails *pd = *p;
pd->something();

---

Regards,
Guido

The problem is p does not seem to point to this object.

*p contains 0xcdcdcd.
thanx
swetha

What does this refer to - subcontent?

Can you post the missing definitions for us to know and then the way you use the vector? How you iterate it? Use CODE tags.

I see... please check the following conditions:

1) What does objptr->subcontent return? (is it a valid pointer)
2) What value does subcontentlist[0] return?

Regards,
Guido

Quote:

---

Originally Posted by exterminator

What does this refer to - subcontent?

Can you post the missing definitions for us to know and then the way you use the vector? How you iterate it? Use CODE tags.

---

Pagedetails *subcontent.


subcontent stores the address of a pagedetails object.

i want to store this in a vector.

rgds
swetha

What is objptr? subcontent appear to be a public member which is a pointer to Pagecontent.

There are rather a lot of pointers here.

yes objptr is also a pointer to Pagedetails, I am accessing the member i.e subcontent outside the class. To access subcontent i have declared
objptr.
rgds
swetha

thanx guys,i got it
rgds
swetha

Quote:

---

Originally Posted by swetha.bsharma

thanx guys,i got it
rgds
swetha

---

And now it remains a mystery. :)

actually the clue was given by GNiewerth (hope the spelling is correct) the content of subcontentlist[0] was empty.

Thanku
rgds
swetha

Cheers,

I´m glad to have helped.

Quote:

---

Originally Posted by swetha.bsharma

Code:

---

std::vector<Pagedetails*> subcontentlist;
 
subcontentlist.push_back(objptr->subcontent);
 
vector<Pagedetails*>::iterator p = subcontentlist.begin();

---

---

I recommend you not store a raw pointer in a vector.
Is there a particular reason why you think this needs to be a pointer instead of a concrete object.

If you really do need a pointer, then I recommend you use a smart pointer like that in the following link:
http://axter.com/smartptr/

Do you ever post anything else about C++ other than trying to sell your smart pointers?
I gave up the battle of trying to beat boost 5 years ago.

The smart pointer link I post also has links to other smart pointers, and information about smart pointers in general.
So I see it as a good starting point for anyone who wants to use smart pointers, regardless if they decide to use my smart pointer or not.

I think the FAQ needs a topic on smart pointers. I should look up the "How do I submit a topic" I guess and then write it.

Quote:

---

Originally Posted by NMTop40

I think the FAQ needs a topic on smart pointers. I should look up the "How do I submit a topic" I guess and then write it.

---

That's a good idea, but maybe an article would be better.

I've been considering writing an article on this, but haven't had the time to put one together.