problems with my code, not sure why

hi, im programming an app in C++. i have a header file that has a 'player' class, but when i try to modify the varuiables of it i get some errors. here its the code:

player class.h:

class player{
public:
float size; //the size of the player
float x;
float y;
float z;
int score;
int lives;
float time;

};

main.cpp: (extract)

player me;
me.size=2; //line 37 here
me.y=5; //line 38



errors:
Error 2 error C2143: syntax error : missing ';' before '.' y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
Error 3 error C4430: missing type specifier - int assumed. Note: C++ does not support default-int y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
Error 4 error C2371: 'me' : redefinition; different basic types y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37

get the same 3 errors for line 38. cheers for any help :)

Did you

Code:

---

#include "player.h"

---

in main.cpp?

Hope that helps.

yeh, i did #include the right file, i also added it into the project through the 'add existing file' thing. its starting to annoy me :(

Try posting the whole project here, there must be something wrong with your .h/.cpp file.

il post it tomorrow... the file is on my account in uni, and im on my house comp at the mo. cheers

ok, heres my code:

____________________________________________

player class.h:

class player{
public:
float size; //the size of the player
float x;
float y;
float z;
int score;
int lives;
float time;

};
_____________________________________________________

main.cpp (only down to the error, as the code is very long):

#include <windows.h>
#include <stdio.h>
#include <mmsystem.h>
#include <math.h>
#include <gl/gl.h>
#include <gl/glu.h>
#include <gl/glaux.h>
#include "tex.h"
#include "MilkshapeModel.h"
#include "player calss.h"


#define COLOUR_DEPTH 16 //Colour depth

typedef struct Mouse
{
int x,y;
}Mouse;



float speedx=0, speedz=0;
float tiltx=0, tilty=0;
float itsx=0, itsy=5, itsz=0;
float rot=0.0;
float rotate=0;
float ySpeed=0;
float yAccel=-0.1;
int falling;
int Walls[1][5];
int ground[2][9];
int collision=false;

Model *robo = NULL;

player me;
me.size=2; ///////////////////////////////////error occurs here
me.y=5;

______________________________________________________

if you havent guessed, im trying to program in game in openGL. i am just using the class to tidy the code up a bit. i havent included the whole main.cpp file as it is about 1000 lines long, and i doubt any of it is causing the problem... or could it?

[edit] also, the filename is actually "player calss.h" because i misstyped it when i saved it, so just included as is.

Reading error messages, it seems for me that name me is already defined, probably as a type name in one of header files. Try different name for your object and check if error still occurs.

Cheers,
Hob

I'm not 100% sure about this because I've never seen it, but your player class does not have a constructor! (This could be your problem.)

Normally you'll have in the header:

Code:

---

player class.h:

class player{
public:
player();
~player();
float size; //the size of the player
float x;
float y;
float z;
int score;
int lives;
float time;
};

---

Along with that, you would have an implementation (or it could be included in the header if needed.

Code:

---

class player{
public:
player(){ };
~player(){ };
...

---

I suspect that the error really occurred on the line preceding the one you point to, which would indicate it could not create an object of the player class.

Hope that helps.

just tried changing it to 'murloc' and then 'randomenamething' and it still came up with the same error. do i need to #include any files in my header file?

i just updated the player class to:

class player{
public:
player(){};
~player(){};
float size; //the size of the player
float x;
float y;
float z;
int score;
int lives;
float time;

};

the error still occurs. is that the right syntax for just keeping it in the class?

hi,

just chk ur spelling...u typed
#include "player calss.h"

instead of "player class.h"

this shud solve ur problem i guess..

Quote:

---

Originally Posted by kaira

hi,

just chk ur spelling...u typed
#include "player calss.h"

instead of "player class.h"

this shud solve ur problem i guess..

---

You need a spell checker. This is a professional programming site, not a teen chat room. Please use real words. Not only does it reflect better on you, but it helps those for whom English isn't their first language.

Quote:

---

Originally Posted by weewun

main.cpp: (extract)

player me;
me.size=2; //line 37 here
me.y=5; //line 38



errors:
Error 2 error C2143: syntax error : missing ';' before '.' y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
Error 3 error C4430: missing type specifier - int assumed. Note: C++ does not support default-int y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
Error 4 error C2371: 'me' : redefinition; different basic types y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37

get the same 3 errors for line 38. cheers for any help :)

---

Since I don't see an entire file (I understand, 1000 lines and everything...), I can only guess.
Your lines 37 and 38 are OUTSIDE any function body? Then compiler assumes (and it says so in the error message) that you define another variable called "me", of a type "int" (by default) and are trying to use "." on it!

Why dont you attach actual code files ?

Quote:

---

Originally Posted by kaira

just chk ur spelling...u typed
#include "player calss.h"

instead of "player class.h"

this shud solve ur problem i guess..

---

This would have produced two different errors: missing include file (some compilers would stop there) and unknown type "Player" on line 36.

Quote:

---

Originally Posted by Krishnaa

Why dont you attach actual code files ?

---

Didn't you see? It's loooong... ;)

If the code is too long to post then my suggestion would be to compile it and post all of the error messages. You originally only posted what you called errors 2-4. What was error 1? You may have decided that it wasn't relevant but you should not do that. Most of the experts on this board understand error messages and can determine the most likely causes.

In addition to posting all of the error messages you should post the code where the first error occurs. We can start with error #1 and go from there.

Zip the whole project and attach the zip file.

Quote:

---

Originally Posted by krmed

I'm not 100% sure about this because I've never seen it, but your player class does not have a constructor! (This could be your problem.)

Normally you'll have in the header:

Code:

---

player class.h:

class player{
public:
player();
~player();
float size; //the size of the player
float x;
float y;
float z;
int score;
int lives;
float time;
};

---

Along with that, you would have an implementation (or it could be included in the header if needed.

Code:

---

class player{
public:
player(){ };
~player(){ };
...

---

I suspect that the error really occurred on the line preceding the one you point to, which would indicate it could not create an object of the player class.

Hope that helps.

---

The compiler will automatically generate a constructor, copy constructor and assignment operator if you do not provide one. However, if you do provide a constructor that takes any number of parameters, you must also provide a default ctor (the compiler will not auto generate one for you).

Viggy

i tried to upload the zipped folder but it was 4mb after being zipped, and too big to upload. in the compilation, there are alot of warnings about various things, such as truncating a double to a float etc. and the first 'error' is a warning.

this warning is:
_______________________________________
Warning 1 warning C4305: 'initializing' : truncation from 'double' to 'float' y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 28
_______________________________________
and all the errors are:
_______________________________________
Error 2 error C2143: syntax error : missing ';' before '.' y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
____
Error 3 error C4430: missing type specifier - int assumed. Note: C++ does not support default-int y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
____
Error 4 error C2371: 'me' : redefinition; different basic types y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 37
____
Error 5 error C2143: syntax error : missing ';' before '.' y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 38
____
Error 6 error C4430: missing type specifier - int assumed. Note: C++ does not support default-int y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 38
____
Error 7 error C2371: 'me' : redefinition; different basic types y:\0501334\my documents\2nd year\graphics programming\new folder\myproj\main.cpp 38
_____________________________________________

after that there are just warnings about my shady coding ;)

This is VERY IMPORTANT: As Hobson and VladimirF have already suggested, you must locate the other variable named 'me' that is conflicting with the one of type 'player' that you have shown in your post.

I can generate the same errors you show with this code:

Code:

---

int me;
player me;
me.size=2;
me.y=5;

---

You can delete the Debug and/or Release folders in your project (the ones that contain object and executable files) before zipping it. I really doubt that you have 4MB of compressed source code.

And another thought: is the code that you show defined outside of a function?

Code:

---

#include "player.h"

player me;
me.size=2; //line 37 here
me.y=5; //line 38

void SomeFunction()
{
}

---

If so, that could account for your at least part of the problem.

i already tried changing 'me' to other variable names, but the same error occured. i also searched the code for any text " me" (with the space) and found no other variable called 'me'.
i have just taken the actault code, instead of thewhole project (thats why it was so big), and zipped it, and attached it to this post.

I was adding to my post the part about making sure that the code causing the errors was not outside of a function and now I see that my suspicion was correct.

It is OK to declare 'player me' outside of a function but initialization of its parameters must be done inside of a function. try moving the two lines that set size and y inside of WinMain().

Better yet, start learning the concept of working with classes by adding an appropriate constructor that takes arguments for size and y:

Code:

---

class player{
public:
float size; //the size of the player
float x;
float y;
float z;
int score;
int lives;
float time;

player(float size, float y)
  : size(size), y(y)
{
}
};


// Now you can declare your player like this:
player me(2,5);

---

My example of adding a constructor is very crude. You should really set all variables to an initialized state even if they aren't included in the parameter list:

Code:

---

player(float size, float y)
  : size(size), y(y), x(0), score(0)...
{
}

---

And it would be a good idea to declare a default constructor in case a player is created without parameters:

Code:

---

player(float size, float y)
  : size(size), y(y), x(0), score(0)...
{
}
player()
  : size(4), x(1), y(1)...
{
}

player me(2,5);  // size=2, y=5
player you;        // size=4, y=1

---

thanks very much! it compiles and runs now! (unfortunatly i still have alot of work to do on it :)) didnt realise that you wre unable to initialise class parameters outside of functions, cheers to everyone who gave this a look!