Printable View
Hi, I know this seems very simple, I have the datatable filled with the records and all i want is to increment it. My code looks like this:
Is this code correct?Code:SqlDataAdapter da = new SqlDataAdapter(cmd);
//this is creating a data table
DataTable dt = new DataTable();
int invNum = da.Fill(dt);
invNum = invNum + 1;
Not sure what you mean? Increment what? Your thread title says otherwise. I understand that you want to read the rows from the data table.
Well, you can do it like this:
RegardsCode:foreach(DataRow dr in dt.Rows)
{
string column1 = dr["your_first_column_name"];
//... and so on.
}
Yea I guess I it was kinda vague, well I'm calling a function in sql server that obtains the highest number from a column called InvoiceNumber in table Sales. In visual Studio 2005 I call the function then when i fill (dt) datatable, it gives 13 as the highest (eg.max(InvoiceNumber)=13)
then when I get that I want to read it as an int and increment it so it becomes 14 and then display 14 at run time...I hope that is more clear. My problem is when i run the program with the code I posted i only get 13...it doesn't increment to 14. Thanks in advance...
I know this doesn't answer your question, but dataadapter.fill() returns the number of rows affected by your query, not the result of your query, that should be being stored in the datatable.
OK here's my code:
I would like to be able to put:Code:SqlConnection dbConnection = new SqlConnection(xmldb);
SqlCommand cmd = new SqlCommand(" SELECT * FROM dbo.fnInvoiceID() ", dbConnection);
cmd.CommandType = CommandType.Text;
SqlDataAdapter da = new SqlDataAdapter(cmd);
DataTable dt = new DataTable();
int invNum = da.Fill(dt);
invNum = invNum + 1;
comboBox4.DataSource = dt;
comboBox4.DisplayMember = "InvoiceNumber";
comboBox4.ValueMember = "InvoiceNumber";
comboBox4.DataSource = invNum;
In this manner I would get the +1 increment that I want. I succesfully obtain 13 from the function...any other suggestions?
When I try:
comboBox4.DataSource = invNum;
I get this error:
"Complex DataBinding accepts as a data source either an IList or an IListSource."
It's telling you the same thing the we did.
so that is the wrong way to get data.Quote:
dataadapter.fill() returns the number of rows affected by your query
just to get you going you can add another column to your SQL that says "InvoiceNumber + 1" and then use that column in your databinding..Quote:
Originally Posted by gggram2013
however, if your SQL will return only one row and a column you may just use the <command object>.ExecuteScalar() and then assign the value straight to a textbox.Code:SqlConnection dbConnection = new SqlConnection(xmldb);
SqlCommand cmd = new SqlCommand(" SELECT *, (InvoiceNumber + 1) AS InvPlusOne FROM dbo.fnInvoiceID() ", dbConnection);
cmd.CommandType = CommandType.Text;
SqlDataAdapter da = new SqlDataAdapter(cmd);
DataTable dt = new DataTable();
int invNum = da.Fill(dt);
invNum = invNum + 1;
comboBox4.DataSource = dt;
comboBox4.DisplayMember = "InvPlusOne";
comboBox4.ValueMember = "InvPlusOne";
Thats totally correct as an int is an int and incremented or not, never a datasource. BTW incrementing simple can be done withQuote:
Originally Posted by gggram2013
But understand this is an invoicenumber but no dataobject !! So the idea you hadCode:invNum++;
Thats a totally wrong concept. Because its a counter only, So incrementing it doesn't give you the next record or whatever you want to achieve.Quote:
I would like to be able to put:
comboBox4.DataSource = invNum;
In this manner I would get the +1 increment that I want. I succesfully obtain 13 from the function...any other suggestions?
By the way, Thanks Thread1! Your example works perfectly, appreciate it. How would it change if I wanted the value in a label instead of a comboBox?
Thread1 told you pretty much exactly how to do it, you should really read the responses to your question.
Yea, when I try to put a label with a dataSource, display member or value member it doesn't work...
You should elaborate on "it doesn't work..." when posting problems in a forum. What doesn't work? What error does it give you?
Well basically I don't know how to code it so as to display the value on a label instead of a comboBox. eg:
I would want to put:Code:da.Fill(dt);
comboBox.DataSource = dt;
comboBox.DisplayMember = "InvPlusOne";
comboBox.ValueMember = "InvPlusOne";
But that does not function since label doesn't have those properties.Code:label.DataSource = dt;
label.DisplayMember = "InvPlusOne";
label.ValueMember = "InvPlusOne";
Nevertheless, I'm gonna use a comboBox and try hiding it meanwhile, so thanks for ur assistance!
Well, you could just read it from the dataset instead of setting the datasource.
Just change the datatable to a dataset and do roughly the following:
Somethin like that should work, I believe (not tested).Code:ds.Tables["yourtablename"].Rows[0]["InvPlusOne"].ToString()
it is not always the case that you have to use databinding (using DataSource) when assigning values from database to a control. if you just want to display a value (scalar), you could assign it to the text/value property of the control. in your case...Quote:
Originally Posted by gggram2013
Code:label.Text = dt[0][0].ToString();
Hey it works Great now. Thanks for ur help Thread1, it was really helpful.
I put:
Appreciate everyone's help!Code:label.Text = dt.Rows[0]["InvPlusOne"].ToString();
George