[RESOLVED] Stange problem in std::map
I'm trying to load a dictionary in memory and everything goes fine. No error, no warning, no memory leak, nothing. Just trying to see how many elements my map has and I dicovered that it is loading less words that the dictionary has. Here is my code.
Code:
UINT CPM2Dlg::LoadVocabolary(void)
{
CStdioFile pFile;
CString temp;
if(pFile.Open("vocabolario.txt",CFile::modeRead | CFile::typeText))
{
while(pFile.ReadString(temp))
{
dataHandler.vocabolary.words.insert(dict_words::value_type(temp,DecodeString(temp)));
}
pFile.Close();
}
return 0;
}
CString & CPM2Dlg::DecodeString(CString & str)
{
int i,length;
CString buffer;
length = str.GetLength();
for(i = 0; i < length; i++)
{
if(str[i] == 'a' || str[i] == 'b' || str[i] == 'c' || str[i] == 'Ã*')
{
buffer += "2";
continue;
}
if(str[i] == 'd' || str[i] == 'e' || str[i] == 'f' || str[i] == 'è' || str[i] == 'é')
{
buffer += "3";
continue;
}
if(str[i] == 'g' || str[i] == 'h' || str[i] == 'i' || str[i] == 'ì')
{
buffer += "4";
continue;
}
if(str[i] == 'j' || str[i] == 'k' || str[i] == 'l')
{
buffer += "5";
continue;
}
if(str[i] == 'm' || str[i] == 'n' || str[i] == 'o' || str[i] == 'ò')
{
buffer += "6";
continue;
}
if(str[i] == 'p' || str[i] == 'q' || str[i] == 'r' || str[i] == 's')
{
buffer += "7";
continue;
}
if(str[i] == 't' || str[i] == 'u' || str[i] == 'v' || str[i] == 'ù')
{
buffer += "8";
continue;
}
if(str[i] == 'w' || str[i] == 'x' || str[i] == 'y' || str[i] == 'z')
{
buffer += "9";
continue;
}
}
str = buffer;
return str;
}
the vocabolary has 245227 elements but the map only shows 222791. If I delete a word from the dictionary (delete fisically a line in the txt file) the number decrease (as I expected). Any clue? Have I done something wrong here?
Re: Stange problem in std::map
Probably there are double (identical) entries in your input.
Re: Stange problem in std::map
the dictionary is taken from the internet and as far as I know there are no duplicate elements.
Re: Stange problem in std::map
Ok what happens if you use a multimap instead?
Re: Stange problem in std::map
didn't try. I've to try and tell you.
Re: Stange problem in std::map
Quote:
Originally Posted by SkyNetTo
... as far as I know there are no duplicate elements.
How did you check/test the presence/absence the duplicate elements?
Re: Stange problem in std::map
;) loaded 245227. Thanks. But why this?
Re: Stange problem in std::map
The second value (the one wich I recover from DecodeString) is the same many times but the first one is always different.
Re: Stange problem in std::map
In DecodeString, what is the purpose of setting "str=buffer" ?
1) Shouldn't you just return buffer ?
2) If you can just return buffer, then pass str by const reference.
Re: Stange problem in std::map
And I forgot to add ... you would need to return buffer by value
not reference.
Re: Stange problem in std::map
Quote:
Originally Posted by SkyNetTo
The second value (the one wich I recover from DecodeString) is the same many times but the first one is always different.
1) You never gave us the definition of your map. That was the first thing you should have posted. The definition could make all of the difference in why you're not seeing all your entries.
2) Return by value, not reference.
3) That function could have been written a lot easier using a lookup table as opposed to all of those if() statements.
4) You could have easily tested if there were truly any duplicates by calling map::find() before the insertion into the map. If map::find() returns a valid iterator, then the claim that there were no duplicates would have been a false claim.
Regards,
Paul McKenzie
Re: Stange problem in std::map
A little more info on why I suggested what I did ...
Code:
dataHandler.vocabolary.words.insert(dict_words::value_type(temp,DecodeString(temp)));
value_type is pair<CString,CString> ... so basically you are executing:
Code:
pair<CString,CString>(temp,DecodeString(temp));
I think that you are assuming that the key (temp) will be the value
before the call to Decode(temp) ... this is not necessarily the case.
DecodeString(temp) changes the value of temp. If you print out
your map, my guess is that the key and value will be the same.
Here is a simplified version of your code (and replaced CString with
string). It prints out the size of the map is 1 (on my system) instead
of the expected 2.
Code:
#include <string>
#include <map>
#include <iostream>
using namespace std;
string & DecodeString(string & str)
{
str = "1";
return str;
}
int main()
{
map<string,string> m;
string temp1 = "n";
m.insert(map<string,string>::value_type(temp1,DecodeString(temp1)));
string temp2 = "m";
m.insert(map<string,string>::value_type(temp2,DecodeString(temp2)));
cout << m.size() << "\n";
}
Re: Stange problem in std::map
Thank you for your all your suggestions. Let start clarifying some things.
My multimap is defines as:
Code:
typedef std::multimap<CString,CString>dict_words
I'm trying to delevelop some kind of T9 used in Cell Phones to write SMS and so I need the decoded string of all the words in the dictionary. When I insert the word in the map I'm expected that one cell will handle the value of the word and its decoded String wich is defines as:
Word: play; DecodedString: 7529 //don't know If I explaind myself.
Once the temp value is inseted in the map I don't need it any more, that's why I'm changing it's value with the content of the decodedString. You said I've to pass string by value and not by reference. You're right but the point is I haven't any clue how to do this (at the right way it is intended). If I place
the compiler says that you are passing a temporary value wich goes out of scope and that's why I copied the context of buffer into str. If there's a better way of doin' this please let me know.
Again thanks to all of you. I'm learning so many things on this forum that I wasn't able to learn anywhere else.
Re: Stange problem in std::map
Quote:
Originally Posted by SkyNetTo
Thank you for your all your suggestions. Let start clarifying some things.
My multimap is defines as:
Once the temp value is inseted in the map I don't need it any more, that's why I'm changing it's value with the content of the decodedString.
As I mentioned above, I believe that the "temp" value gets changed
before it gets inserted as the key into the map.
Quote:
Originally Posted by SkyNetTo
return buffer;
the compiler says that you are passing a temporary value which goes out of scope and that's why I copied the context of buffer into str. If there's a better way of doin' this please let me know.
return by value instead. So the signature for DecodeString would be:
Code:
CString CPM2Dlg::DecodeString(const CString & str)
(no & after the first CString)
Re: Stange problem in std::map
Shame on me. As you said the value of temp was changing before inserting it to map. So my map has only numbers and not words. Everythins works now even if I change the typedef from multimap to map. That was the reason why I had less cells than the words of the dictionary.
Re: Stange problem in std::map
Quote:
Originally Posted by Paul McKenzie
3) That function could have been written a lot easier using a lookup table as opposed to all of those if() statements.
How can this be done. Can I make a map with 26 (letters of the dictionary) elements and than search for the corresponding value?
Re: Stange problem in std::map
Is this the right way?
Code:
typedef std::map<char,CString>look_up;
look_up lkTable;
lkTable.insert(look_up::value_type('a',"2"));
lkTable.insert(look_up::value_type('b',"2"));
lkTable.insert(look_up::value_type('c',"2"));
lkTable.insert(look_up::value_type('d',"3"));
lkTable.insert(look_up::value_type('e',"3"));
lkTable.insert(look_up::value_type('f',"3"));
lkTable.insert(look_up::value_type('g',"4"));
lkTable.insert(look_up::value_type('h',"4"));
lkTable.insert(look_up::value_type('i',"4"));
lkTable.insert(look_up::value_type('j',"5"));
lkTable.insert(look_up::value_type('k',"5"));
lkTable.insert(look_up::value_type('l',"5"));
lkTable.insert(look_up::value_type('m',"6"));
lkTable.insert(look_up::value_type('n',"6"));
lkTable.insert(look_up::value_type('o',"6"));
lkTable.insert(look_up::value_type('p',"7"));
lkTable.insert(look_up::value_type('q',"7"));
lkTable.insert(look_up::value_type('r',"7"));
lkTable.insert(look_up::value_type('s',"7"));
lkTable.insert(look_up::value_type('t',"8"));
lkTable.insert(look_up::value_type('u',"8"));
lkTable.insert(look_up::value_type('v',"8"));
lkTable.insert(look_up::value_type('w',"9"));
lkTable.insert(look_up::value_type('x',"9"));
lkTable.insert(look_up::value_type('y',"9"));
lkTable.insert(look_up::value_type('z',"9"));
CString CPM2Dlg::DecodeString(const CString & str)
{
int i,length;
CString buffer;
std::map<char,CString>::iterator iter;
length = str.GetLength();
for(i = 0; i < length; i++)
{
for(iter = dataHandler.lkTable.begin(); iter != dataHandler.lkTable.end(); ++iter)
{
if(str[i] == iter->first)
{
buffer += iter->second;
break;
}
}
}
return buffer;
}
this method is working btw.
Re: Stange problem in std::map
There is no need to have a loop on iter.
1) If the only values of s[i] are 'a' thru 'z' you can simply use:
Code:
for(i = 0; i < length; i++)
{
buffer += lkTable[ s[i] ];
}
2) if other values of s[i] are possible:
Code:
for(i = 0; i < length; i++)
{
iter = lkTable.find( s[i] );
if (iter != lkTable.end())
{
buffer += iter->second
}
}
Re: Stange problem in std::map
;) you're right. Thanks a lot.
