Printable View
How can I activate a MDI window after this one has been hidden in systemtray ?
I have tried:
is shown, but not activated. I have to click on this window in order to be activated...Code:ShowWindow(SW_RESTORE);
SetForegroundWindow();
also, I have tried:
the same result ... How can I activate this MDI window after has been shown ?Code:ShowWindow(SW_RESTORE);
SetForegroundWindow();
BringWindowToTop();
SetFocus();
ShowWindow(SW_SHOW);
ActivateFrame(SW_SHOW);
Where do you call this code from?
Along the lines of what Victor is asking... Are you calling this from the same process the mdi window is in or from a separate process?
I call these methods in the CMainFrame code:Quote:
Originally Posted by VictorN
Code:void CMainFrame::On0Restore()
{
// TODO: Add your command handler code here
ShowWindow(SW_RESTORE);
SetForegroundWindow();
// ::BringWindowToTop(GetSafeHwnd());
// ::SetFocus(GetSafeHwnd());
// ::SetForegroundWindow(GetSafeHwnd());
// ::ShowWindow(GetSafeHwnd(), SW_SHOW);
}
I am call these methods from the same process, from the same thread.Quote:
Originally Posted by Arjay
Did you debug this code? Is this method called?Quote:
Originally Posted by mesajflaviu
Of course that I've debugged. The only way to get the real focus is to call MessageBox (or a modal dialog) after I bring the MDI window to foreground. But this is not what I want. I only need to get the main frame of my app to foreground and set up as focused, ready to get another user commands.
OK! What message do you handle calling this
Could you post a small project reproducing this behavior?Code:void CMainFrame::On0Restore()
Is coming from a system tray icon right click menu item.Quote:
Originally Posted by VictorN
Again:Quote:
Originally Posted by mesajflaviu
Quote:
Originally Posted by VictorN
I ask you for a small test project just because I have no time to create my own one and then try to guess how to simulate your problem!
Ok, I'll try to create a small project for this. I don't know if I could built today. But I come back. Seem very strange this issue because the called methods seem reliable and clear.Quote:
Originally Posted by VictorN
In fact, the app has single instance pattern. So, the issue occur when app is already started, and when user try to start another instance and a system tray balloon is shown, and user click on this volume, and then is fired code from the first post. And didn't work ok, instead of MDI get focus, I saw the app flash the task bar icon few times. So, I have tried this code too:Quote:
Originally Posted by Arjay
with the same result.Code:ShowWindow(SW_RESTORE);
HWND hForegdWnd = ::GetForegroundWindow();
DWORD dwCurID = ::GetCurrentThreadId();
DWORD dwForeID = ::GetWindowThreadProcessId(hForegdWnd, NULL);
::AttachThreadInput(dwCurID, dwForeID, TRUE);
::SetForegroundWindow(m_hWnd);
::SetFocus(m_hWnd);
::AttachThreadInput(dwCurID, dwForeID, FALSE);
still waiting for the test project.
So what started out as a post wondering why focus can't be set on an MDI application has now turned into a single instance tray notify application?Quote:
Originally Posted by mesajflaviu
Clearly it's a bit more complex. That being the case, Victor's ask of a sample app that repros the behavior is probably your best chance of receiving help.
I'll try to make a test project. The same result I got if I notify the user with a random system tray balloon and user click to that balloon, the behavior is the same. So, the issue is the same as I posted first time. I give you this extra details in order to have a clear image about this issue, that is all.Quote:
Originally Posted by Arjay
I have built a test program that illustrate the issue. Just start it and wait 5 seconds. Should see a system tray icon balloon. Click on that balloon, and you'll see that the main frame is shown, but doesn't get the focus.
Look at the messages you're handling in CSystemTray::OnTrayNotification(UINT wParam, LONG lParam)
I suspect you probably want to handle some left button messages
OK, I have tested your sample.Quote:
Originally Posted by mesajflaviu
If I changed the CMainFrame::On0Restore() tothen I could very easy get a keyboard input of CMainFrame. I just typed Alt+F and what I see isCode:void CMainFrame::On0Restore()
{
ShowWindow(SW_RESTORE);
SetForegroundWindow();
}
Attachment 35880
I tried is with double click, with right mouth button click and with a left click on the popup menu.
Yes, you are right, but please do this trial from Windows Explorer. I mean: go in Debug folder, and start the app from there, and wait 5 seconds, and then click on that balloon. This is the real situation.
Hmm, in that case it doesn't get (or, maybe just loose) the focus.:eek::eek:Quote:
Originally Posted by mesajflaviu
I updated the sample project because a class inside the project has errors in x64 configuration. Thank you for your time.
It's really frustrating when you tell somebody what the problem is and they ignore your post.Quote:
Originally Posted by mesajflaviu
I told you where to look
@GCDEF, thank you for your time and sorry if I cause you any issue. I did checked what you said, but in that location, CSystemTray::OnTrayNotification, I don't saw any problem. In that handler, is managed the tray notification, and that notification work fine. Please tell me if I miss understood something.
Look at the messages you're processing.Quote:
Originally Posted by mesajflaviu
WM_RBUTTONUP
WM_LBUTTONDBLCLK
NIN_BALLOONUSERCLICK
I don't see anything that would handle a single left button click on the try icon.
You should get all that CE stuff out of there too. It's just cluttering stuff up.
No, on icon single left button event is happen nothing. On icon double click the app is shown, on icon right click the context menu is shown and on click on tray balloon is calling CMainFrame::On0Restore method (which is not work well).
I used this code from another programming site, I used as I found it. I can clean up CE things, of course.
Which is exactly what I said. I showed you the messages you're processing, and they're all working. Add code to make the left button work.Quote:
Originally Posted by mesajflaviu
Well, I would that, but it would help me ? Because the issue here is that CMainFrame is not activate it. Is shown at user click on tray balloon, but is not active . .. see my image and my sample project. Of course, I can try to call CMainFrame::On0Restore on icon left click, but right now this method is called from tray balloon, and is not working. Sorry if I miss understood what you are tried to say.
I guess implementing and testing what GCDEF suggested would be much faster than posting this message and waiting for the replies. :rolleyes:Quote:
Originally Posted by mesajflaviu
I wouldn't post it if I didn't think it would help. You have a function that handles tray notifications. CSystemTray::OnTrayNotification(UINT wParam, LONG lParam). Step through it and see how it works.Quote:
Originally Posted by mesajflaviu
It handles some messages, all of which work. It doesn't handle a left button message so nothing is happening.
I uploaded new version of project, I clean up CSystemTray class from CE stuff, but only from CSystemTray::OnTrayNotification method. I added the case for WM_LBUTTONDOWN, where I put a TRACE macro.
I have tried:
had no effect.Code:void CMainFrame::On0Restore()
{
// TODO: Add your command handler code here
ShowWindow(SW_RESTORE);
// BringWindowToTop();
// SetForegroundWindow();
DWORD lockTimeOut = 0;
HWND hCurrWnd = ::GetForegroundWindow();
DWORD dwThisTID = ::GetCurrentThreadId(),
dwCurrTID = ::GetWindowThreadProcessId(hCurrWnd, 0);
if (dwThisTID != dwCurrTID)
{
::SystemParametersInfo(SPI_GETFOREGROUNDLOCKTIMEOUT, 0, &lockTimeOut, 0);
::SystemParametersInfo(SPI_SETFOREGROUNDLOCKTIMEOUT, 0, 0, SPIF_SENDWININICHANGE | SPIF_UPDATEINIFILE);
::AllowSetForegroundWindow(ASFW_ANY);
::SetForegroundWindow(GetSafeHwnd());
::BringWindowToTop(GetSafeHwnd());
}
if (dwThisTID != dwCurrTID)
{
::SystemParametersInfo(SPI_SETFOREGROUNDLOCKTIMEOUT, 0, (PVOID)lockTimeOut, SPIF_SENDWININICHANGE | SPIF_UPDATEINIFILE);
::AttachThreadInput(dwThisTID, dwCurrTID, FALSE);
}
}
Good grief dude. All you need to do is copy some code from one of the messages that does work into your left button code. I don't know how much simpler to make it. Of course it didn't work, there's no code hooked up to it. The OnRestore code was working.
Once you get it working by following GCDEFs advice and copy the working code to where you need it, do yourself a favor and take your code to the next level.
Do this by refactoring and remove all the duplicate code. In other words put one copy of the copied code into a method, and call that method on other places in the code. You end up with fewer lines of code and only need to debug one method.
For those folks that like to have labels for things, this is called the DRY principle; meaning, "Don't Repeat Yourself".
I have made those CSystemTray changes only because GCDEF told me that. But I don't know what is the purpose of this change. Sorry. The reported issue is on activating CMainFrame (MDI) window. And this MDI window activation could be done from anywhere, not from CSystemTray::whatever-method only.
Sorry, I saw your message just now. Can you explain what you said with: "The OnRestore code was working" ? I have tried again, but I saw no change (meant is not working correctly).Quote:
Originally Posted by GCDEF
Thank you.
Did you write any code to go with your left button down message yet?Quote:
Originally Posted by mesajflaviu
When I moved the click on balloon code to icon left click the MDI app activation has been made, indeed. But I need this behavior on balloon click, not on icon left click. So, I am thinking how to simulate icon left click when user made click on balloon. However, CMainFrame::On0Restore code is not ok. I guess that code should work as expected. And is not happen.
You've been saying consistently that you need the left button on the tray icon to work. The balloon code works for me. Why are you saying On0Restore is not ok?Quote:
Originally Posted by mesajflaviu
I guess I found the miss understanding here: I need to be functional the left click on tray balloon, not left click on the icon.
So, let say we have the same call to CMainFrame::On0Restore method on icon left click and on balloon left click, ok ?
When I call CMainFrame::On0Restore from left click button, the MDI window activation is correct, because NNN app has the focus already.
When I call CMainFrame::On0Restore from left click on balloon, the MDI window activation is NOT correct, because MDI is not gain the focus. Here is the issue.
Code:void CMainFrame::On0Restore()
{
// TODO: Add your command handler code here
ShowWindow(SW_RESTORE);
SetForegroundWindow();
}
And did you tried that code by clicking on tray balloon ? And when you tried this code have you started the application not from Visual Studio debugger but from Windows Explorer ?
The code from above is not working if the app NNN is started from Windows Explorer and is activated through left click on balloon (not on icon left click)Quote:
Originally Posted by GCDEF
Another attempt:
still not working correctly.Code:void CMainFrame::On0Restore()
{
// TODO: Add your command handler code here
ShowWindow(SW_RESTORE);
DWORD dwThreadID = GetWindowThreadProcessId(m_hWnd, NULL);
AttachThreadInput(GetWindowThreadProcessId(GetForegroundWindow()->GetSafeHwnd(), NULL),
GetCurrentThreadId(), TRUE);
SetWindowPos(&CWnd::wndTopMost, NULL, NULL, NULL, NULL, SWP_NOMOVE | SWP_NOSIZE);
SetWindowPos(&CWnd::wndNoTopMost, NULL, NULL, NULL, NULL, SWP_NOMOVE | SWP_NOSIZE);
SetForegroundWindow();
SetActiveWindow();
SetFocus();
AttachThreadInput(dwThreadID, GetCurrentThreadId(), FALSE);
}
I guess you should investigate the difference between starting the .exe from VS and from Explorer. And how is this problem related to the tray...
Sorry, I have currently a lot of work, so cannot help you more. :cry: