case:__LINE__ problem

[khaldoun KASSEM]

Hi


I have the folowing in my code:
#define crReturn(z) \
do {\
crLine=__LINE__; return (z); case __LINE__:;\
} while (0)

and when I call crReturn(z) in my program I get an error:
D:\SSH.C(707) : error C2051: case expression not constant

how can I solve this problem.
i use visual C++ 6.0
thank you

[Pryrates]

Hi,

I don't know, what you want to do with that macro.
Can you explain, what you want, please?

Bye, Pryrates.

[khaldoun KASSEM]

Hi
I don't write this code but i need to use i.
I have a C and files and headers that I need to use but when
compiling i get that error.

and the code is too long and complexe and I have not the time to change it.
I think if i missed something in the settings...

thank you for help

khaldoun

[Pryrates]

Hi,

if you use the macro, the code will expanded to:

do {
crLine=__LINE__; return 0; case __LINE__:;
} while(0);

In my opinion, it is senseless. And incorrect, because you can use "case" only with "switch".

I would ask the author of the code, what he want to do.

Bye, Pryrates.

[khaldoun KASSEM]

the code is the following:

#define crBegin1 static int crLine = 0;
#define crBegin2 switch(crLine) { case 0:;
#define crBegin crBegin1; crBegin2;
#define crFinish(z) } crLine = 0; return (z)
#define crFinishV } crLine = 0; return
#define crReturn(z) \
do {\
crLine=__LINE__; return (z); case __LINE__:;\
} while (0)
#define crReturnV \
do {\
crLine=__LINE__; return; case __LINE__:;\
} while (0)

and in the main() he do:

crBegin;

next_packet:

pktin.type = 0;
pktin.length = 0;

for (st->i = st->len = 0; st->i < 4; st->i++) {
while ((*datalen) == 0)
crReturn(4 - st->i);

the problem is in case:__LINE__: the compiler doesn't consider that __LINE__ is constant.

thank you for help

[Pryrates]

Hi,

I think, __LINE__ is not a constant for the the compiler.
I don't know, how you can change the code. Sorry, I have no idea.

Bye, Pryrates.

[khaldoun KASSEM]

thank you because you tried to help.
I solved the problem, it was a bug in visual C++, I just changed the compiler setting from "Program Database for Edit and Continue' to "Program Database" and the code works very well

thank you again

khaldoun

[Graham]

I still think you need to find the original author and reprogram him with a large axe. That sort of trickery crap is among the worst programming sins around. There is no need for it and it should be stamped out immediately.