Destructor for a pointer in class

[pdk5]

Hi,

Sorry I have not been here for long .. In my last visit got some really good tips to improve my c++

I have a legacy class something like this and i added the following structs inside.

class CClass : public CBaseClass, public ClassC
{
public:
virtual ~CClass();
struct CreateSessInfo
{
// Following fields are valid when the CCR num is 0
CreateSessionReq stCrSessReq;
CClass * pClassInstance1;
};

struct DedBearerInfo
{
CClass * pClassInstance2;
u8 nProcId;
};
};

Now my query is that , in the existing destructor for this class, I need to delete these pClassInstance1, and pClassInstance2

thanks,
~p

[Richard.J]

You don't show where pClassInstance1 and pClassInstance2 are created (using new).
If they are created inside CClass/DedBearerInfo, then you have to delete them in the destructor. You might be better off using a smart pointer like std::unique_ptr/std::shared_ptr (C++11).

HTH,
Richard

And next time, please use code tags to properly format your code.

[pdk5]

Thanks a lot Richard,

I have tried to use the same format as the existing code.

These pointers are assigned as follows: In the class member function:

CClass::memberfunction()
{
:
stCrSessInfo.pCpgwInstance = this;
:
}

[Richard.J]

Well, if you just use the pointer to store a reference to the 'parent' class, you must not delete it. Otherwise, in the CreateSessInfo destructor you would delete your object containing the CreateSessInfo instance.

Basic rule: if you create an object using 'new', you have to 'delete' it.
If you just store the address of something you did not create, don't delete it.

[pdk5]

Thanks a lot Richard, your advice is much appreciated

[VictorN]

Thanks a lot Richard,

I have tried to use the same format as the existing code.

to preserve the "same format as the existing code" you must use CODE tags. See the Announcement: ..., section Before you post....