Linker error with pure virtual function.

[Prandr]

I am making a static library. when I try to use it in an application
I get following errors in MVS 2013:
error LNK2001: unresolved external symbol "private: virtual void __thiscall serial::ArduinoMessageParser:arse(class ATL::CStringT<wchar_t,class StrTraitMFC<wchar_t,class ATL::ChTraitsCRT<wchar_t> > >)" (?parse@ArduinoMessageParser@serial@@EAEXV?$CStringT@_WV?$StrTraitMFC@_WV?$ChTraitsCRT@_W@ATL@@@@@ATL@@@Z)
error LNK2001: unresolved external symbol "private: virtual void __thiscall serial::ArduinoMessageParser:arse(class ATL::CStringT<wchar_t,class StrTraitMFC<wchar_t,class ATL::ChTraitsCRT<wchar_t> > >)" (?parse@ArduinoMessageParser@serial@@EAEXV?$CStringT@_WV?$StrTraitMFC@_WV?$ChTraitsCRT@_W@ATL@@@@@ATL@@@Z)
error LNK2019: unresolved external symbol "protected: __thiscall serial::AbstractSerialParser::AbstractSerialParser(void)" (??0AbstractSerialParser@serial@@IAE@XZ) referenced in function "public: __thiscall serial::ArduinoMessageParser::ArduinoMessageParser(struct HWND__ *)" (??0ArduinoMessageParser@serial@@QAE@PAUHWND__@@@Z)
1>E:\Doc\Unterricht\CJ2\SerialComm_Arduino\Debug\ArduinoController.exe : fatal error LNK1120: 2 unresolved externals

relevant declarations in corresping files neglecting neseccary includes:

	class AbstractSerialParser
	{
	protected:
		virtual void parse(CString s)=0;
		AbstractSerialParser();
	public:

		void operator()(const CString &serial_string){ std::thread(&AbstractSerialParser::parse, this, serial_string).detach(); }
		virtual ~AbstractSerialParser(){};
	};

class ArduinoMessageParser : public AbstractSerialParser
	{
	private:
		HWND target_window;
virtual void parse(CString)override;
		
	public:
		
		ArduinoMessageParser() = delete;
		ArduinoMessageParser(HWND h) :target_window(h){}
		ArduinoMessageParser(const ArduinoMessageParser&) = default;
		~ArduinoMessageParser(){};

void ArduinoMessageParser::parse(CString message)
	{
	///implementation for parser
	}

I probably miss just a minor detail, but spent a few hours swithout fsuccedding to figure this out

[RichardDuNord]

The error message from the linker refers to "ArduinoMessageParser:arse". Check your code to see if "parse" is misspelled somewhere.

[Richard.J]

The linker expects both classes to be defined in the namespace 'serial'. From the code you posted, it's not clear if you really defined the classes in this namespace.

[superbonzo]

void operator()(const CString &serial_string){ std::thread(&AbstractSerialParser::parse, this, serial_string).detach(); }

as a side note, you're probably using a non-standard implementation of std::thread here ( maybe, vs2013 implemented an early draft ? ) because destroying a detached std::thread will invoke std::terminate()...

[2kaud]

The error message from the linker refers to "ArduinoMessageParser:arse". Check your code to see if "parse" is misspelled somewhere.

The linker error message as displayed is not shown properly as some of the chars are displayed as an emotive. The correct error message contains

serial::ArduinoMessageParser::Parse(

[ahoodin]

in

class ArduinoMessageParser : public AbstractSerialParser

try changing

virtual void parse(CString)override;

to

virtual void parse(CString s )override;

any joy?

[Prandr]

You all gussed wrong.
What really happened I stepped on the same rake as in the thread http://forums.codeguru.com/showthrea...rtual-function
this thread could be merged into it

[ahoodin]

You could have kept that under your hat, but
maybe your not a self promoter.