Vector of Class

[spider84]

hey, this is my first post here, and dont know if it's related with the forum. if it s not the case m just redirect me without assaulting me
Here is my problem:

Contact.h

class Contact{
	public:  
		//Constructors
		Contact(const string& fname, const string&  lname, const string&  phone);
		void addContact(vector<Contact>&);
                void setFirstName(string fname);
		void setLastName(string lname);
		void setPhone(string phone);
               string getFirstName();
		string getLastName();
		string getPhone();
                friend class ContactList;
private:
		//Variables
		string fname;
		string lname;
		string phone;
}

ContactList.h

#include "Contact.h"
#include <vector>

using namespace std;

class ContactList{

private:
		static vector <Contact> myList;
}

Contact.cpp

#include "ContactList.h"
#include <iostream>
            Contact::Contact(const string& myFname, const string& myLname, const string& myPhone){
	fname = myFname;
	lname = myLname;
	phone = myPhone;
}
void Contact::addContact(vector<Contact>&myList){
			string fname;
			string lname;
			string phone;
                        cout<<"\tFirst Name :> ";
					getline(cin,fname);
			cout<<"\tLast Name :> ";
					getline(cin,lname);
			cout<<"\tPhone # :> ";
					getline(cin,phone);
                        Contact newContact(fname, lname, phone, address, city, state);
			myList.push_back(newContact);
}

UseContact.cpp

#include "ContactList.h"
#include <iostream>
#include <fstream>
#include <string>

using namespace std;

int main(){	
	vector<Contact>v;
       ContactList myContact1(fname, lname, phone);
       cout<<"\t\t----- Add Contact -----"<<endl;	
		myContact1.addContact(v);
}

I don't know how to make it work, Which header should i call.
Contact.h is include in ContactList.h
However, i Wasn't;t able to determine how to list all my contacts.

[2kaud]

What is the purpose of class ContactList - as it only contains one private static member with no constructors etc? What are you trying to achieve? Is this homework - if so what is the assignment?


Does addContact() belong in class Contact or should it be in class ContactList and take a parameter of Contact which then adds to the myList vector? Why is myList static?

[spider84]

Hi,
thank you for answering.
I have to implement a new Header that contains a vector of Contact.
The vector ContactList should contain all my contacts.
I don't know if addContact should be in the ContactList class or Contact class. I m not sure which one is more effective.
I implemented that function in Contact class, and it is not recognized.

[spider84]

i have a constructor for the ContactList class. i implemented it as public:
ContactList(Contact);

[2kaud]

The vector ContactList should contain all my contacts.
I don't know if addContact should be in the ContactList class or Contact class. I m not sure which one is more effective.

I would consider that addContact goes in contactList. I don't know what your exercise asks, but consider

#include <iostream>
#include <string>
#include <vector>
using namespace std;

class Contact {
public:
	Contact(const string& cfname, const string&  clname, const string&  cphone) : fname(cfname), lname(clname), phone(cphone) {};
	Contact() {};

	friend ostream& operator<<(ostream& os, const Contact& con);

private:
	string fname;
	string lname;
	string phone;
};

ostream& operator<<(ostream& os, const Contact& con)
{
	return os << con.fname << " " << con.lname << " " << con.phone;
}


class ContactList {
public:
	void addContact(const Contact& cont) {
		conList.push_back(cont);
	}

	void addContact(const string& fname, const string& lname, const string& phone) {
		conList.emplace_back(fname, lname, phone);
	}

	void display() const
	{
		for (const auto& c : conList)
			cout << c << endl;
	}

private:
	vector<Contact> conList;
};

int main()
{
	ContactList conlst;
	string ans;

	do {
		string fname, lname, phone;

		cout << "first name: ";
		cin >> fname;
		cout << "last name: ";
		cin >> lname;
		cout << "phone: ";
		cin >> phone;
		conlst.addContact(fname, lname, phone);

		cout << "Add another contact ? (Y/N) ";
		cin >> ans;

	} while (ans == "Y" || ans == "y");

	cout << endl;
	conlst.display();
}

which is a 'bare bones' contact list based around a vector.

[saraedward123]

what are you trying to find

[2kaud]

what are you trying to find

The answer to life, the universe and everything.