How to fix this warning?

[OneEyeMan]

Hi, guys,
I have following code:

int bufferSize = 1024;
SQLSMALLINT lenUsed;
for( int i = 0; i < numCols; i++ )
{
    autoincrement = 0;
    columnNames[i] = new SQLWCHAR[sizeof( SQLWCHAR ) * SQL_MAX_COLUMN_NAME_LEN + 1];
    ret = SQLColAttribute( stmt_colattr, (SQLUSMALLINT) i + 1, SQL_DESC_LABEL, columnNames[i], bufferSize, &lenUsed, NULL );
}

Compiling this with MSVC 2010, I'm getting:

warning C4244: 'argument' : conversion from 'int' to 'SQLSMALLINT', possible loss of data

on the SQLColAttribute() call.

How do I fix the warning?

Thank you.

[GCDEF]

You could define i as a SQLUSMALLINT, or you could just ignore it.

[2kaud]

Try

SQLSMALLINT bufferSize = 1024;

as the bufferlength param to SQLColAttribute() is typed as SQLSMALLINT - not int. See https://docs.microsoft.com/en-us/sql...ibute-function

[OneEyeMan]

@2kaud:
That was it.
Thank you.

[VictorN]

Or you may replace int with short...

[Larnaco]

replacing int with short is the best way I think

[2kaud]

The bufferlength parameter of function SQLColAttribute() is defined as type SQLSMALLINT. Therefore a variable of this type should be passed. Whilst currently SQLSMALLINT equates to type short - and therefore passing a variable of type short will currently also avoid the compiler warning, IMO this type equivalence shouldn't be assumed as the underlying type of SQLSMALLINT could change in future releases. Always best to use the specified type.