|
-
March 2nd, 2004, 04:07 AM
#1
Horrible code needs code review .... Anybody ?
Hi
i need a better way of doing all of these if / else statements
any ideas ?
Code:
if (nCodePage == 0000) // (obsolete!) R/3 System character set
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 120) // EBCDIC ISO-1 (Latin 1)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1100) // ASCII ISO 8859/1 (Latin 1)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 410) // EBCDIC ISO-2 (East. Europe, Latin 2)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 500) // EBCDIC ISO-5 (Russian)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 610) // EBCDIC ISO-9 (Turkish)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 700) // EBCDIC ISO-7
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 800) // EBCDIC ISO-8 (Hebrew)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1400) // ASCII ISO 8859/2 (Latin 2)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1500) // ASCII ISO 8859/5 (Russian)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1600) // ASCII ISO 8859/3
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1610) // ASCII ISO 8859/9 (Turkish)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1700) // ASCII ISO 8859/7 (Greek)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1802) // ASCII ISO 8859/8 (Hebrew)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 4001) // OCR-A (ASCII)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 4004) // OCR-B (ASCII)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 8000) // Japanese ISO Shift-JIS
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 1802) // ASCII ISO 8859/8 (Hebrew)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 8300) // Chinese (traditional)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 8400) // Chinese (simplified)
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 8500) // Korean ISO KSC 5601
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 8600) // Thai ISO TIS620-2529
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (nCodePage == 'ISO ')
{
// ** have to choose between ** //
if (strOutput == "Big5")
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
else if (strOutput == "GB23")
{
m_pFiller->AddText("Input code page", strCode);
m_pFiller->AddText("Output code page", strOutput);
m_pFiller->AddText("Language key", strEndOf);
}
}
Thanks in advance
P
Posting Permissions
- You may not post new threads
- You may not post replies
- You may not post attachments
- You may not edit your posts
-
Forum Rules
|
Click Here to Expand Forum to Full Width
|