Array question

[brianlb]

Why does this program only display the last value in the array and not all 10?

#include <iostream>
using namespace std;

int main()
{
    const int NUM_MEN = 10;
    int fish[NUM_MEN], cought = 0;

    for (int count = 0; count < NUM_MEN; count++)
    {
        cout << "How many fish did fisherman " << count+1 << " catch? ";
        cin >> fish[cought];
    }

    for (int count = 0; count < NUM_MEN; count++)
    {
        cout << "\nFisherman " << count+1 << " cought " << fish[cought] << " fish" << endl << endl;
    }
    return 0;
} 

[marceln]

Because:
1) When you populated the array you forgot to increment "cought". The amounts for all fishermen are stored in fish[0];

2) You should print fish[count] not fish[cought]. cought is always 0, and I don't think you should even use it, since you have the for loop counter.

[brianlb]

Because:
1) When you populated the array you forgot to increment "cought". The amounts for all fishermen are stored in fish[0];

2) You should print fish[count] not fish[cought]. cought is always 0, and I don't think you should even use it, since you have the for loop counter.

ok so i change cought to count, delcare int count at the beginning of the program, but what i don't understand is, isn't count just a counter for the for loop?

[Lindley]

Sure count is a counter for the loop. I'm not sure what your point is though.....?

[krmed]

If you look at this loop

    for (int count = 0; count < NUM_MEN; count++) 
    { 
        cout << "How many fish did fisherman " << count+1 << " catch? "; 
        cin >> fish[cought]; 
    }

you are putting the answer into fish[cought], but cought is never being incremented, so in essence, the number of fish cought for each of the 10 fishermen is being stored in fish[0], with each one overwriting the previous one.

The same is true for this loop

    for (int count = 0; count < NUM_MEN; count++) 
    { 
        cout << "\nFisherman " << count+1 << " cought " << fish[cought] << " fish" << endl << endl; 
    }

In both cases, you need to have

fish[count]

instead of

fish[cought]

Hope that helps.

[brianlb]

ok, I think I understand it a little better. Think I need to find a place on the web where I can do some more reading on how arrays and loops work together, separately I understand them, but putting them together is where I have trouble.

[GCDEF]

Learning programming from web sites is likely to prove to be an exercise in futility. Get a good book that's been peer reviewed, is widely accepted and takes you through the steps in a logical order.

There's been an unfortunate increase in people trying to learn for putting bits and pieces they find on various web site together. Most of them just end up confused and misguided.

FWIW, caught is spelled with an "a", not an "o".