string in Stack or Heap ?

[Mutant_Fruit]

if you want to pass a reference as paramater, you need to add the 'ref' modifier.

public static void swap(ref string s1, ref string s2)
{
   ...
}

Strings are reference types so you don't 'copy' them by passing them to anther function. The ref parameters are unnecessary for this case.