Problems with strcmp

[ultio]

Hey,
basically I'm starting with C++, I've already learned quite a lot and I now wanted to start with a simple game of Tic Tac Toe.
So now that's the problem:
I'm basically trying to check if there's an "X" or a number saved in a char of an array. But that doesn't seem to work:

if (!strcmp(field[1],"X") == 0)

So I'm just wondering what I'm doing wrong, I guess I just need a different function, but I simply can't find something that would work.
Thanks in advance.

[Lindley]

What is the type of "field"?

Since char is a primitive type, you can compare individual characters just using ==. You need to use a character literal rather than a string literal though.

[ultio]

Well, the declaration of the variable looks like that:

char field[11] ={'0','1','2','3','4','5','6','7','8','9'};

But throughout the process of the game and code the numbers may change to 'X' or 'O'. That's why I think I need strcmp, because you can't compare letters with a simple == operator, can you?!

[Ajay Vijay]

if (!strcmp(field[1],"X") == 0)

Using '!' as well as '==0' check?
Weird!

[Ajay Vijay]

You can:

if ( field[some_position] == 'X' ) ...

But why you created array of 11 elements and assigned 10 elements, Tic Tac Toe only has 9.
When you exactly know how many elements are there, and there is actually none of string operations involved, you need not to worry about null character!

[GCDEF]

strcmp checks null terminated strings for equality. field[1] is not a null terminated string. Use strstr or just iterate each char in the array looking for it.

[Ajay Vijay]

Use strstr or just iterate each char in the array looking for it.

I would recommend strchr for single character search.

[lion.king]

if ( field[some_position] == 'X' ) should solve your problem.

no need of strcmp as u field is char.