Function problem

[fuzzylr]

I am trying to make a function that repeats till I say exit out. For some strange reason it's complaining about the answers.

Code:

int add()
{
        char answer;
        int a,b;
        int total;

        do
        {
                std::cout<<"Enter two numbers: ";
                std::cin>>a,b;

                total = a+b;
                std::cout<< total <<"\n\n";
                std::cout<<"Do you wish to continue: Y/N";
                std::cin>>answer;
        } while (answer = y || answer = Y);

        std::cout<<"Returning to menu\n\n";
        return 0;
}

Error:

In file included from index.cpp:2:0:
functions.cpp: In function âint add()â:
functions.cpp:9:11: error: âyâ was not declared in this scope
functions.cpp:20:34: error: âYâ was not declared in this scope

[GCDEF]

90 posts is enough to know about code tags.

Look at this line. What do you see wrong?

while (answer = y || answer = Y);

[fuzzylr]

90 posts is enough to know about code tags.

Look at this line. What do you see wrong?

while (answer = y || answer = Y);

Actually, I thought I had them right. However, it's not working. I even googled it up on V board.

[fuzzylr]

90 posts is enough to know about code tags.

Look at this line. What do you see wrong?

while (answer = y || answer = Y);

Sorry, I had the "/" in the wrong direction. I actually did use tags.

[fuzzylr]

Look at this line. What do you see wrong?

while (answer = y || answer = Y);

I'm not sure honestly. It's been a long time since I've done programming. I've probably made a silly mistake. I've tried several different variants.

while (answer == y | answer == Y);

while ((answer = y) | (answer == Y));

while (answer == "y" | answer == "Y");

[Russco]

= is assignment
== is the equality operator
y is a variable named y
'y' is a char

now you should be able to fix it

[fuzzylr]

= is assignment
== is the equality operator
y is a variable named y
'y' is a char

now you should be able to fix it

Thank you sir. I knew it was a simple mistake.

[VladimirF]

One more:
|| is a logical OR
| is a bit-wise OR
(in this case produce the same result)

[fuzzylr]

One more:
|| is a logical OR
| is a bit-wise OR
(in this case produce the same result)

Yea, I had googled "or" statements. I was feeling more that "||" was the correct use of the "or" statement but I was having a hard time finding "||" as a valid use for "or" or even if it could be used. It also makes sense that it worked that way regardless of which one I used.

[MrViggy]

Also, this line:

std::cin>>a,b;

Does not do what you think it does...

Viggy

[fuzzylr]

Also, this line:

std::cin>>a,b;

Does not do what you think it does...

Viggy

Yes, I completely rewrote that function. It would have been nice to get it to take both numbers on the same line but I separated it and tossed in a switch for handling the yes or no pieces and error handling.

[VladimirF]

It would have been nice to get it to take both numbers on the same line ...

std::cin >> a >> b;

[fuzzylr]

I would like some advice. I would like to reduce the use of goto in this function even though it's fairly simple. What if I wanted to reuse bits and pieces of code? Can I do that or once I get into If / else or While loops do I need to move the code pieces inside the loop till it breaks out or what not. It seems kind of pointless to duplicate the code. I guess that is why the goto is so appealing in this type of instance.

int add()
{
        char answer;
        int a,b;
        int total;

        start:

        std::cout<<"Enter first number: ";
        std::cin>>a;
        std::cout<<"Enter Second number: ";
        std::cin>>b;

        total = a+b;
        std::cout<<"\nSum: "<< total <<"\n\n";

        question:
        std::cout<<"Do you wish to continue: Y/N ";
        std::cin>>answer;

        switch (answer)
        {
                case 'y': goto start;
                case 'Y': goto start;
                case 'n': goto end;
                case 'N': goto end;
                default:
                std::cout<<"Invalid characters.  Use Y/N or y/n.\n\n";
                goto question;
        }

        end:
        std::cout<<"Returning to menu";
        sleep(3);
        return 0;
}

would it be bad if I did cases like this?

 case 'y' || 'Y': code sample here

My Goal is to consolidate the code down as small as possible while still being functional.

[fuzzylr]

std::cin >> a >> b;

When you do that though. What happens if the user does [23] & [85] but types it out like this "2385"???

[VladimirF]

When you do that though. What happens if the user does [23] & [85] but types it out like this "2385"???

Did you try?
it will go into the first variable, and will sit there waiting for the second entry.