vector

[Rajesh1978]

The below code is giving me segment fault during delete [] (*iter) sometimes
Please suggest what is the fault. Is it not the proper way to delete the vector with char *

#include <iostream>
#include <vector>

using namespace std;

int main()
{
    vector<char*> nameList;
    for (int i=0;i<1000;++i)
    {
        char *p = new char[10];
        strcpy(p,"test");
        nameList.push_back(p);
    }

    vector<char*>::iterator itr;
    for(itr=nameList.begin();itr!=nameList.end();++itr)
    {
        cout<<*itr<<endl;
    }

    vector<char*>::iterator iter;
    for(iter= nameList.begin();iter!=nameList.end();++iter)
    {
        delete[] (*iter);
    }
    return 0;
}

[laserlight]

Assuming that std::bad_alloc is not thrown, it looks okay to me, except for the missing #include <cstring>.

[Paul McKenzie]

The below code is giving me segment fault during delete [] (*iter) sometimes

1) Please state the compiler and if necessary, operating system you're using (compiler name and version -- for example, don't just say g++, say g++, the version of g++ being used, and Linux as the OS).

2) You are missing the <cstring> header, as laserlight pointed out.

3) Other than that, the code should work correctly, unless again, std::bad_alloc() was thrown because of the call to new[].

Regards,

Paul McKenzie

[GCDEF]

Compiles and runs without error for me.

[Lindley]

I suppose I should point out that you can save yourself the trouble if you use a vector<string> instead.

[nuzzle]

Please suggest what is the fault.

Since the code looks okay it's probably a linker error. Check that you're using the correct object files and libraries.

[Rajesh1978]

Thanks all.
This a extracted code from my actual project where it was crashing. Due to some other memory corruption the crash was happening and the BT was pointing some time some where. I doubted that the deletion using iterator may invalidating the iterator and it was crashing as it has pointed to this iterator deletion once.

[Paul McKenzie]

Thanks all.
This a extracted code from my actual project where it was crashing.

No, what you posted is a completely different program then the one you are running that is causing the issue. You posted a complete, valid program with no runtime issues.

In general, when you have corrupted memory, any part of your application is susceptible to error. The place where the application breaks down is usually not where the problems originated.

Regards,

Paul McKenzie