How can I use my current code to prompt the computer to output back a series of MIDI

[DomDienst]

I'm still new to C++ so im still trying to get my head around a few things. All my validation works fine. The user must input a MIDI note that consists of at 2-3 characters, be between A-G, the last character must be a digit, and if the length is 3 the middle character must be a sharp(#).

What I must do now is allow the user to enter a series of notes for both MELODY and BASS, to then store them, to then output them back to the user in order they entered them. At the moment the user can only enter 2 notes before the program closes itself. What should I do?

using namespace std;
#include <iostream>
#include <cstdlib>

using namespace std;

//********START UP MENU*******//

int StartUpMenu()
{
    while (1)
    {
        int choice;

        cout <<"::menu option::\n\n"
            <<"1. Bass\n"
            <<"2. Melody\n"
            <<"3. Exit\n"
            <<"Would you like to work with Bass or Melody first? Please enter 1 for Bass or 2 for Melody or 3 to Exit:";

        cin >> choice;

        if(choice == 3) break;


        else if (choice == 1)
        {
            system ("CLS");
            cout<<"1. Bass \n\n";
            system ("PAUSE");
            system ("CLS");
        }

        else if (choice == 2)
        {
             system ("CLS");
            cout<<"2. Melody \n\n";
            system ("PAUSE");
            system ("CLS");
        }

        else if (choice > 3 || choice < 1)
        {
            system ("CLS");
            cout<<"2. Melody \n\n";
            system ("PAUSE");
            system ("CLS");
        }

    }

    return 0;
}

    //********VALIDATION FOR NOTE NAME********//

    string GetNote()
    {
        string input;
        int loop = 1;
        cout << "Hello, please type in a note: "<< endl;
        cin >> input;
        while (loop < 5000)
        {

            if (input.length() < 2 || input.length() > 3) //Step 1: If note name length is less than 2 OR more than 3, return false
            {
            cout<<"Note must be either 2 or 3 characters long!\n";
            cin >> input;
            }

            else if (((int)input[0] < 65)|| ((int)input[0] > 71 )) //Step 2: The note must be/(or be) between A and G
            {
            cout<<"The note must be between A to G!\n";
            cin >> input;
            }

            else if (input.length() == 2 && (isdigit(input[1]) == false))
                //(isdigit(note[GetValidNote()-1]) == false) //Step 3: If true, the last character must be a digit
            {
            cout<<"Last character must be a digit!\n";
            cin >> input;
            }
            else if (input.length() == 3 && (isdigit(input[2]) == false))
                //(isdigit(note[GetValidNote()-1]) == false) //Step 3: If true, the last character must be a digit
            {
            cout<<"Last character must be a digit!\n";
            cin >> input;
            }

             else if (input.length() == 3 && input[1] !='#') //Step 4: If note length is 3 note[1] (character 2) must be '#'.
            {
            cout<<"Invalid sharp note\n";
            cin >> input;
            }
            else
            {
                return input;
            }
        }

    }
    //********GET MIDI********//

    int MidiStorage(string validnote)
    {
        int MidiLetter = validnote[0] - 65;

        int Note;
        int Octave = validnote[validnote.length()-1]; //THIS IS A MATHMATICAL EQUATION TO GET THE COMPUTER TO REALISE WHAT AN OCTAVE IS USING THE MIDI NOTE CHART.

        if(validnote[0] == 'A')

        {
            MidiLetter = 9;
        }

        else if (validnote[0] == 'B')

        {
            MidiLetter = 11;
        }

        else if (validnote[0] == 'C')

        {
            MidiLetter = 12;
        }

        else if (validnote[0] == 'D')
        {
            MidiLetter = 14;
        }

        else if (validnote[0] == 'E')
        {
            MidiLetter = 16;
        }

        else if (validnote[0] == 'F')
        {
            MidiLetter = 17;
        }

        else if (validnote[0] == 'G')
        {
            MidiLetter = 19;
        }
        /////////////////////

        int midivalue = MidiLetter + (Octave * 12);
        if(validnote.length() == 3)
        {
            midivalue += 1;
        }

    }

    //Validation

    int main()
    {
    string note;
    int midivalue;
    StartUpMenu(); //This function brings you to the start up menu
    note = GetNote(); //This function tells the computer what note between A-G and  the user has given
    cout << "The note you chose is: " << note << endl;
    MidiStorage(note);
    GetNote();
    return 0;
    }

[2kaud]

When posting code, please use code tags so that the code is readable. Go Advanced, select the formatted code and click '#'.

I'll have look at the code later today.

[DomDienst]

Thanks for that, I was trying to figure out how to do that myself but you got there before me!

I am only willing to accept any sort of help from people online! I will be grateful for what ever help I receive. Thanks.

[2kaud]

MidiStorage() doesn't actually return a value. Do you want to return midivalue?

Do you want to store them as the chars entered - or as the midivalue? Do you need to access the entered notes randomly or only in the order entered?

To store the entered values, you can use one of the c++ STL containers. Vector is probably the easiest.

Do you need to also store whether a note is a bass note or a melody note - or do you need to store these separately?

[DomDienst]

I would like to store them as midivalue.

The notes don't have to be in the order entered but I would prefer if they were. How would I go about using a Vector in this instance?

I also need to store the bass notes and the melody notes separately.

[2kaud]

For info on vector, see http://www.cplusplus.com/reference/vector/vector/

Sample code to obtain 10 notes and store them in a vector as midivalue and then to display the values in the vector is

int main()
{
	StartUpMenu(); //This function brings you to the start up menu

	vector<int> notes;

	for (int i = 0; i < 10; ++i) {
		string note = GetNote(); //This function tells the computer what note between A-G and  the user has given
		cout << "The note you chose is: " << note << endl;
		notes.push_back(MidiStorage(note));
	}

	for (const auto& n : notes)
		cout << n << " ";

	cout << endl;

	return 0;
}

[DomDienst]

What I am doing here is taking a number of MIDI values from the user and storing it in an array. What I would now like to do is output what the user typed in back to the user.

using namespace std;
#include <iostream>
#include <cstdlib>
#include <string>

using namespace std;
//int notenumber

int MidiStorage(string validation);

struct Note
{
	string name;
	int midiNumber;
	int length;
};

//**************************************************************VALIDATION NOTE LENGTH***********************************************//

/*while ValidateNoteLength(int length)//Step 1 - If notelength is not a digit then it will return false.

{
	if (length == false)
	{
		cout << "Note length must be a digit/number, please re-enter";
		return false;
	}
	if (length <= 0 || length > 16) //Step 2 - If notelength is less than or equal to 0 or more than 16 return false.
	{
		cout << "Note length value cannot be less than 1 or more than 16, please re-enter";
		return false;
	}
	return true;
}*/

//******************************************************VALIDATION FOR NOTE NAME**********************************************//
string GetNote()
{
	string input;
	int loop = 1;
	cout << "Hello, please type in a note: " << endl;
	cin >> input;
	while (1)
	{

		if (input.length() < 2 || input.length() > 3) //Step 1: If note name length is less than 2 OR more than 3, return false
		{
			cout << "Note must be either 2 or 3 characters long!\n";
			cin >> input;
		}

		else if (((int)input[0] < 65) || ((int)input[0] > 71)) //Step 2: The note must be/(or be) between A and G
		{
			cout << "The note must be between A to G!\n";
			cin >> input;
		}

		else if (input.length() == 2 && (isdigit(input[1]) == false))
			//Step 3: If true, the last character must be a digit
		{
			cout << "Last character must be a digit!\n";
			cin >> input;
		}
		else if (input.length() == 3 && (isdigit(input[2]) == false))
			//Step 3: If true, the last character must be a digit
		{
			cout << "Last character must be a digit!\n";
			cin >> input;
		}

		else if (input.length() == 3 && input[1] != '#') //Step 4: If note length is 3 note[1] (character 2) must be '#'.
		{
			cout << "Invalid sharp note\n";
			cin >> input;
		}
		else
		{
			return input;
		}
	}

}

//**************************************************************START UP MENU****************************************************//


void StartUpMenu()
{
	const int numNotes = 4;
	Note melody[numNotes];
	Note bass[numNotes];

	while (1)
	{
		int choice;

		cout << "::menu option::\n\n"
			<< "1. Bass\n"
			<< "2. Melody\n"
			<< "3. Exit\n"
			<< "Would you like to work with Bass or Melody first? Please enter 1 for Bass or 2 for Melody or 3 to Exit:";

		cin >> choice;

		if (choice == 3) break;


		if (choice == 1)
		{
			system("CLS");
			cout << "1. Bass \n\n";

			for (int i = 0; i < numNotes; i++)
			{
				

				cout << "Bass\n";

				bass[i].name = GetNote();
				cin >> bass[i].length;
				bass[i].midiNumber = MidiStorage(bass[i].name);
			}

			system("PAUSE");
			system("CLS");


		}

		else if (choice == 2)
		{
			system("CLS");
			cout << "2. Melody \n\n";

			for (int i = 0; i < numNotes; i++)
			{
				cout << "Melody\n";

				melody[i].name = GetNote();
				cin >> melody[i].length;
				melody[i].midiNumber = MidiStorage(melody[i].name);

				//cout << melody[i].name;
			}

			system("PAUSE");
			system("CLS");
		}

	}

	return;
}


//*****************************************************************************VALIDATION FOR NOTE NAME**********************************************************//



int MidiStorage(string validnote)
{
	int MidiLetter = validnote[0] - 65;

	int Note;
	int Octave = validnote[validnote.length() - 1] - 48; //THIS IS A MATHMATICAL EQUATION TO GET THE COMPUTER TO REALISE WHAT AN OCTAVE IS USING THE MIDI NOTE CHART.

	if (validnote[0] == 'A')

	{
		MidiLetter = 9;
	}

	else if (validnote[0] == 'B')

	{
		MidiLetter = 11;
	}

	else if (validnote[0] == 'C')

	{
		MidiLetter = 12;
	}

	else if (validnote[0] == 'D')
	{
		MidiLetter = 14;
	}

	else if (validnote[0] == 'E')
	{
		MidiLetter = 16;
	}

	else if (validnote[0] == 'F')
	{
		MidiLetter = 17;
	}

	else if (validnote[0] == 'G')
	{
		MidiLetter = 19;
	}

	int midivalue = MidiLetter + (Octave * 12);
	if (validnote.length() == 3)
	{
		midivalue += 1;
	}

	return midivalue;
}


//*******************************************MAIN FUNCTIONS******************************************//

int main()


{	
	

StartUpMenu();
	
		return 0;
}

[2kaud]

As an example for Bass, consider

for (int i = 0; i < numNotes; i++)
{
    cout << "Bass\n";
    bass[i].name = GetNote();
    cin >> bass[i].length;
    bass[i].midiNumber = MidiStorage(bass[i].name);
}

for (int i = 0; i < numNotes; ++i)
    cout << bass[i].name << " " << bass[i].length << " " << bass[i].midiNumber << endl;

Note that the arrays melody and bass are local to the function StartUpMenu() and so can't be accessed outside of this function. If they need to be (eg in main()), then they either need to be defined ad global, or defined within main() and passed as parameters to the function.