A question regarding *s++

[monarch_dodra]

Sure it would, given the post-increment semantics which are at the heart of what we're discussing.

StringIterator& operator++(int)
{
pos++;
return *this;
}

The real problem is that you implemented post-increment as pre-increment, breaking standard conventions and assumptions.

I'm pretty sure 4 or 5 people will tell you the same in a 5 minute time span.